Skip to content

Fix varyrun not respecting bounds and not iterating array variables#4404

Merged
timothy-nunn merged 2 commits into
mainfrom
papercut-varyrun
Jul 3, 2026
Merged

Fix varyrun not respecting bounds and not iterating array variables#4404
timothy-nunn merged 2 commits into
mainfrom
papercut-varyrun

Conversation

@clmould

@clmould clmould commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Description

Closes #4058
Also fixes varyrun to vary iteration variable values within factor * initial value, instead of updating each iteration
Also small fix to get value of f_nd_impurity_electrons(13) from the in_dat.data instead of from its default value

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter

codecov-commenter commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.82%. Comparing base (699eb86) to head (12a345c).

Files with missing lines Patch % Lines
process/core/io/in_dat/base.py 60.00% 2 Missing ⚠️
process/core/io/vary_run/config.py 0.00% 1 Missing ⚠️
process/core/io/vary_run/tools.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4404      +/-   ##
==========================================
- Coverage   48.82%   48.82%   -0.01%     
==========================================
  Files         151      151              
  Lines       29405    29408       +3     
==========================================
+ Hits        14358    14359       +1     
- Misses      15047    15049       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread process/core/io/in_dat/base.py Outdated
Comment thread process/core/io/in_dat/base.py Outdated
@clmould clmould force-pushed the papercut-varyrun branch from 34dd443 to 37c6fe9 Compare July 1, 2026 18:29
@clmould clmould force-pushed the papercut-varyrun branch from 37c6fe9 to 12a345c Compare July 3, 2026 09:21
@clmould clmould marked this pull request as ready for review July 3, 2026 09:22
@clmould clmould requested a review from a team as a code owner July 3, 2026 09:22
@timothy-nunn timothy-nunn changed the title Varyrun fixes Fix varyrun not respecting bounds and not iterating array variables Jul 3, 2026
@timothy-nunn timothy-nunn merged commit f95b094 into main Jul 3, 2026
10 of 11 checks passed
@timothy-nunn timothy-nunn deleted the papercut-varyrun branch July 3, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 VaryRun not varying all iteration variables

3 participants