Skip to content

Update add-vars.md#4332

Open
timothy-nunn wants to merge 7 commits into
mainfrom
3664-update-add-varsmd
Open

Update add-vars.md#4332
timothy-nunn wants to merge 7 commits into
mainfrom
3664-update-add-varsmd

Conversation

@timothy-nunn

@timothy-nunn timothy-nunn commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Updated the guide for adding variables, inputs, scan vars, figures of merit, and iteration vars. They needed a refresh due to changes in the Python conversion, recent data structure changes, and enumification.

I have also reduced the need for users to manually increment some variables (was not possible for the scan variables due to circular imports).

@timothy-nunn timothy-nunn linked an issue Jun 17, 2026 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.78%. Comparing base (89e1ebe) to head (a1eca61).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4332      +/-   ##
==========================================
- Coverage   48.79%   48.78%   -0.02%     
==========================================
  Files         151      151              
  Lines       29383    29392       +9     
==========================================
+ Hits        14337    14338       +1     
- Misses      15046    15054       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn marked this pull request as ready for review June 18, 2026 08:32
@timothy-nunn timothy-nunn requested a review from a team as a code owner June 18, 2026 08:32
@timothy-nunn

Copy link
Copy Markdown
Collaborator Author

Requesting a couple of reviews to ensure these docs make sense and are sufficiently detailed

@timothy-nunn timothy-nunn force-pushed the 3664-update-add-varsmd branch from 0aba1cf to d1dd370 Compare June 18, 2026 14:55

@clmould clmould left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All minor things, mostly suggested changes, but otherwise happy with the content

Comment thread documentation/source/development/add-vars.md Outdated
Comment thread documentation/source/development/add-vars.md Outdated
Comment thread documentation/source/development/add-vars.md
Comment thread documentation/source/development/add-vars.md Outdated
Comment thread documentation/source/development/add-vars.md Outdated
Comment thread documentation/source/development/add-vars.md Outdated
Comment thread documentation/source/development/add-vars.md Outdated
Comment thread process/data_structure/numerics.py
Comment thread process/data_structure/numerics.py Outdated
Comment thread documentation/source/development/add-vars.md Outdated
@clmould clmould self-assigned this Jun 18, 2026
Comment thread documentation/source/development/add-vars.md Outdated
Comment thread documentation/source/development/add-vars.md
Comment thread documentation/source/development/add-vars.md Outdated
Comment thread documentation/source/development/add-vars.md Outdated
timothy-nunn and others added 2 commits June 23, 2026 14:14
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
Co-authored-by: Christopher Ashe <91618944+chris-ashe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update add-vars.md

4 participants