Skip to content

Update of documentation for #4223#4241

Open
jmorris-uk wants to merge 1 commit into
mainfrom
4223-default-indat-doesnt-work
Open

Update of documentation for #4223#4241
jmorris-uk wants to merge 1 commit into
mainfrom
4223-default-indat-doesnt-work

Conversation

@jmorris-uk
Copy link
Copy Markdown
Contributor

@jmorris-uk jmorris-uk commented May 12, 2026

Description

Minor change to documentation pages to reflect:

  • there is no longer a "default" process IN.DAT and
  • if process is run with no input file given it no longer will look for a file called IN.DAT, it will run process --help.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@jmorris-uk jmorris-uk requested a review from a team as a code owner May 12, 2026 12:21
@jmorris-uk jmorris-uk linked an issue May 12, 2026 that may be closed by this pull request
@clmould clmould self-assigned this May 12, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.38%. Comparing base (60443bd) to head (ebf56c8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4241      +/-   ##
==========================================
- Coverage   51.40%   51.38%   -0.03%     
==========================================
  Files         151      151              
  Lines       30055    30039      -16     
==========================================
- Hits        15451    15435      -16     
  Misses      14604    14604              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@clmould clmould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of rearranging please (see comments)

Also, there is a reference to a default IN.DAT in input-guide.md - could this be removed as well please?

will produce the following output files in the same directory as the input file:

```
my_file_name_OUT.DAT
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, could you update this list of output files please as this is no longer correct, eg here are the outputs I got from running examples/data/large_tokamak_IN.DAT with --full-output:

Image

process
```
In this case the output files will be `OUT.DAT` and `MFILE.DAT`.
PROCESS input file names end in IN.DAT. If no input file name is given as an argument in the command line, PROCESS will run `process --help`.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sentences aren't needed any more

In this case the output files will be `OUT.DAT` and `MFILE.DAT`.
PROCESS input file names end in IN.DAT. If no input file name is given as an argument in the command line, PROCESS will run `process --help`.

The `examples/data` folder in the repository has the commonly used `large_tokamak_IN.DAT` input file, which can be a useful starting point for new users.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be moved further down (see later comment), so this section can begin with 'The user can provide a named input file...'

```

---------------

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the sentence about the examples/data dir from above to here please

```bash
process --help
```

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add here 'or with process' please in the same bash formatting as the line above?

will produce the following output files in the same directory as the input file:
```
my_file_name_OUT.DAT
my_file_name_MFILE.DAT
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, could you also add the SIG_TF.json and _process.log files here too please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default IN.DAT doesn't work

3 participants