Fwbs dataclass#4230
Conversation
also in hcpb use blanket_vars to point to vars instead of blanket_library module
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4230 +/- ##
==========================================
- Coverage 51.81% 51.49% -0.32%
==========================================
Files 150 150
Lines 30296 30101 -195
==========================================
- Hits 15697 15501 -196
- Misses 14599 14600 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
left a comment
There was a problem hiding this comment.
I haven't quite checked everything but here are my comments on the main logic changes
There was a problem hiding this comment.
I'm a little confused why this file has been created?
There was a problem hiding this comment.
There was a circular import between the first wall and blanket, and this removed that. Also these functions aren't specific to the blanket and are used by other modules so made sense to remove them from blanket_library
There was a problem hiding this comment.
I'll move this to another PR


Description
Checklist
I confirm that I have completed the following checks: