Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4206 +/- ##
==========================================
- Coverage 51.78% 51.78% -0.01%
==========================================
Files 150 150
Lines 30285 30321 +36
==========================================
+ Hits 15684 15702 +18
- Misses 14601 14619 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d455a45 to
976c7e5
Compare
@timothy-nunn This is how it's currently working on main |
@clmould the image is not working for me, but that surprises me. I don't think thats how it worked when I last used vary run, and I don't think that is how it should work because the intermediate files are not useful imo. This PR seems like a good opportunity to fix this. |
…next__method so no more files are created once max iterations reached, update docs and varyrun example
976c7e5 to
295ea72
Compare
|
Keeping the intermediate files for now as removing them wasn't as straightforward as initially thought. #4227 |


Description
Closes #4204
Stops creating IN.DAT, MFILE.DAT and OUT.DAT in VaryRun runs (so now only makes the 0_, 1_ etc), update the
__next__method so no files are created once the max iterations are reached (as before if it reached max iterations it would create the next IN.DAT then error saying it can't find the associated MFILE), add messages to make clear if that iteration's file converged or not, update docs and varyrun exampleChecklist
I confirm that I have completed the following checks: