Skip to content

varyrun stop IN.DAT being created#4206

Open
clmould wants to merge 4 commits intomainfrom
4204-varyrun-file-creation
Open

varyrun stop IN.DAT being created#4206
clmould wants to merge 4 commits intomainfrom
4204-varyrun-file-creation

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Apr 27, 2026

Description

Closes #4204
Stops creating IN.DAT, MFILE.DAT and OUT.DAT in VaryRun runs (so now only makes the 0_, 1_ etc), update the __next__ method so no files are created once the max iterations are reached (as before if it reached max iterations it would create the next IN.DAT then error saying it can't find the associated MFILE), add messages to make clear if that iteration's file converged or not, update docs and varyrun example

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Apr 27, 2026 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 29.09091% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.78%. Comparing base (62a4d95) to head (5801446).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/vary_run/config.py 20.45% 35 Missing ⚠️
process/core/io/vary_run/tools.py 62.50% 3 Missing ⚠️
process/main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4206      +/-   ##
==========================================
- Coverage   51.78%   51.78%   -0.01%     
==========================================
  Files         150      150              
  Lines       30285    30321      +36     
==========================================
+ Hits        15684    15702      +18     
- Misses      14601    14619      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould marked this pull request as ready for review April 27, 2026 18:03
@clmould clmould requested a review from a team as a code owner April 27, 2026 18:03
@clmould clmould force-pushed the 4204-varyrun-file-creation branch 2 times, most recently from d455a45 to 976c7e5 Compare April 28, 2026 10:03
@clmould clmould changed the title varyrun stop IN.DAT being created and being default varyrun stop IN.DAT being created May 1, 2026
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old files are now not being deleted:

Image

We only want the 2_* files to be left (in this example) as the others a produced by non-convergent input files

@clmould
Copy link
Copy Markdown
Collaborator Author

clmould commented May 5, 2026

The old files are now not being deleted:

Image We only want the `2_*` files to be left (in this example) as the others a produced by non-convergent input files

@timothy-nunn This is how it's currently working on main

@timothy-nunn
Copy link
Copy Markdown
Collaborator

The old files are now not being deleted:
Image
We only want the 2_* files to be left (in this example) as the others a produced by non-convergent input files

@timothy-nunn This is how it's currently working on main

@clmould the image is not working for me, but that surprises me. I don't think thats how it worked when I last used vary run, and I don't think that is how it should work because the intermediate files are not useful imo. This PR seems like a good opportunity to fix this.

clmould added 3 commits May 6, 2026 16:21
…next__method so no more files are created once max iterations reached, update docs and varyrun example
@clmould clmould force-pushed the 4204-varyrun-file-creation branch from 976c7e5 to 295ea72 Compare May 6, 2026 15:39
@clmould
Copy link
Copy Markdown
Collaborator Author

clmould commented May 6, 2026

Keeping the intermediate files for now as removing them wasn't as straightforward as initially thought. #4227

@clmould clmould requested a review from timothy-nunn May 6, 2026 15:43
Comment thread process/core/io/vary_run/config.py Outdated
Comment thread process/core/io/vary_run/config.py Outdated
Comment thread process/core/io/vary_run/config.py Outdated
@clmould clmould requested a review from timothy-nunn May 7, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VaryRun file creation

4 participants