Fix @platejs/list headless React dependency - #5129
Merged
Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: 8ca1698 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
GauthierPLM
approved these changes
Sep 17, 2026
GauthierPLM
left a comment
Contributor
There was a problem hiding this comment.
Looks good for me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fixes #5128
🧭 Task plan: docs/plans/5128-fix-list-headless-react-dependency.md
🟢 95-100% confidence
@platejs/list@53.1.3install failed to import without React; the headless ownership test failed before the fixpnpm check; autoreview clean✅ Outcome
@platejs/listcan be imported from plain Node without React installed. The root entry graph no longer reachesreactorreact-compiler-runtime, while@platejs/list/reactkeeps the existing list wrapper markup.The headless base plugin intentionally has no default React renderer. Static rendering remains caller-configured, as in the existing
BaseListKit.pnpm checkstill reports the pre-existing sidebar exhaustive-deps warning but exits 0.🏗️ Design
BaseListPlugin; attach the JSXbelowNodesrenderer inListPlugin.🧪 Verified
pnpm --filter @platejs/list testpnpm turbo typecheck --filter=./packages/listpnpm --filter @platejs/list buildplatejs, thenimport '@platejs/list'with React absentreactandreact-compiler-runtimepnpm brlpnpm lint:fix.agents/skills/autoreview/scripts/autoreview --mode local --stream-engine-outputpnpm check