Feature/userinfo

.gitignore

@@ -515,3 +515,7 @@ inspect-report/
 
 # Agent folders
 .claude
+
+# Exclude Impeccable skill and hooks
+.github/skills/impeccable/
+.github/hooks/impeccable.json

CLAUDE.md

@@ -44,6 +44,7 @@ When I ask a question or make an observation, respond with an answer - do NOT ju
 
 ## Testing & Git
 
+- **No VMACS production calls**: Unit tests, local environments, and test environments must NEVER send requests to the VMACS production server. All external HTTP requests (e.g., VMACS, Instinct, IAM API) must be mocked using in-memory databases and mock HTTP clients/factories to prevent production spam.
 - **UI**: Test UI changes with Playwright MCP (modals, forms, keyboard nav)
 - **API**: Use Playwright MCP to visit endpoints, APIs require browser auth, `curl` fails
 - **Branch & merge flow**: Branch off `main`, named `feature/`|`fix/`|etc. plus the JIRA ticket if applicable (e.g. `feature/VPR-104-clinical-scheduler`). After code review, merge into `Development` and push, which deploys to TEST. After the PR is approved on TEST, merge into `main`. Every change goes through `Development` first.

Viper.sln.DotSettings

@@ -2,4 +2,6 @@
 	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=OptimizeUsings/@EntryIndexedValue">&lt;Profile name="OptimizeUsings"&gt;&lt;CSOptimizeUsings&gt;&lt;OptimizeUsings&gt;True&lt;/OptimizeUsings&gt;&lt;EmbraceInRegion&gt;False&lt;/EmbraceInRegion&gt;&lt;RegionName&gt;&lt;/RegionName&gt;&lt;/CSOptimizeUsings&gt;&lt;/Profile&gt;</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=ShortenReferences/@EntryIndexedValue">&lt;Profile name="ShortenReferences"&gt;&lt;CSShortenReferences&gt;True&lt;/CSShortenReferences&gt;&lt;/Profile&gt;</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=RemoveRedundancies/@EntryIndexedValue">&lt;Profile name="RemoveRedundancies"&gt;&lt;CSRemoveCodeRedundancies&gt;True&lt;/CSRemoveCodeRedundancies&gt;&lt;RemoveCodeRedundancies&gt;True&lt;/RemoveCodeRedundancies&gt;&lt;CSRemoveRedundantArgumentDefaultValues&gt;True&lt;/CSRemoveRedundantArgumentDefaultValues&gt;&lt;CSRemoveRedundantInitializers&gt;True&lt;/CSRemoveRedundantInitializers&gt;&lt;/Profile&gt;</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=PartialTypeWithSinglePart/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=PartialMethodWithSinglePart/@EntryIndexedValue">DO_NOT_SHOW</s:String>
 </wpf:ResourceDictionary>

scripts/lint-any.js

@@ -218,6 +218,7 @@ function runOxfmtCheckBatch(files) {
         stdio: "pipe",
         cwd: projectRoot,
         encoding: "utf8",
+        shell: true,
     })
 
     if (result.error) {
@@ -269,6 +270,7 @@ function runOxfmtCheck(files, fix) {
             const result = spawnSync("npx", ["oxfmt", "--write", ...batch], {
                 stdio: "inherit",
                 cwd: projectRoot,
+                shell: true,
             })
             if (result.error || result.status !== 0) {
                 allPassed = false

test/Areas/Directory/VMACSServiceTest.cs

@@ -31,7 +31,6 @@ public void BuildSearchPath_IncludesAuthToken()
 
         [Theory]
         [InlineData("https://vmacs-qa.example.edu")]
-        [InlineData("http://vmacs.example.edu/")]
         public void IsValidBaseUrl_True_ForAbsoluteHttpUrls(string baseUrl)
         {
             Assert.True(VMACSService.IsValidBaseUrl(baseUrl));
@@ -44,7 +43,7 @@ public void IsValidBaseUrl_True_ForAbsoluteHttpUrls(string baseUrl)
         [InlineData("not-a-url")]
         [InlineData("/relative/path")]
         [InlineData("vmacs-qa.example.edu")]
-        [InlineData("ftp://vmacs.example.edu")]
+        [InlineData("ftp://vmacs-qa.example.edu")]
         [InlineData("file:///etc/passwd")]
         public void IsValidBaseUrl_False_ForMissingOrNonHttpUrls(string? baseUrl)
         {

test/Services/UserInfoServiceTests.cs

@@ -0,0 +1,207 @@
+using Microsoft.EntityFrameworkCore;
+using Microsoft.Extensions.Caching.Memory;
+using Microsoft.Extensions.Configuration;
+using Microsoft.Extensions.Logging;
+using NSubstitute;
+using System.Net;
+using System.Text;
+using Viper.Areas.Directory.Models;
+using Viper.Areas.Directory.Services;
+using Viper.Classes.SQLContext;
+using Viper.Models.AAUD;
+using Viper.Models.Courses;
+
+namespace Viper.test.Services
+{
+    public class UserInfoServiceTests
+    {
+        private readonly ITestOutputHelper _output;
+
+        public UserInfoServiceTests(ITestOutputHelper output)
+        {
+            _output = output;
+        }
+
+        private static DbContextOptions<TContext> CreateInMemoryOptions<TContext>() where TContext : DbContext
+        {
+            return new DbContextOptionsBuilder<TContext>()
+                .UseInMemoryDatabase(databaseName: Guid.NewGuid().ToString())
+                .Options;
+        }
+
+        [Fact]
+        public async Task TestGetUserInfo_WithSyntheticData()
+        {
+            _output.WriteLine("[DEBUG] Starting TestGetUserInfo with fully synthetic data...");
+
+            // 1. Arrange Config & Cache
+            var configData = new Dictionary<string, string?>
+            {
+                { "Instinct:ApiUrl", "https://synthetic.instinctvet.com/" },
+                { "Credentials:InstinctApi", "synthetic-password" }
+            };
+            var config = new ConfigurationBuilder()
+                .AddInMemoryCollection(configData)
+                .Build();
+
+            var memoryCache = new MemoryCache(new MemoryCacheOptions());
+
+            // 2. Mock HttpClientFactory
+            var mockHandler = new MockHttpMessageHandler(request =>
+            {
+                var uri = request.RequestUri?.ToString() ?? "";
+                if (uri.Contains("auth/token"))
+                {
+                    return new HttpResponseMessage(HttpStatusCode.OK)
+                    {
+                        Content = new StringContent("{\"access_token\": \"synthetic-token\", \"expires_in\": 86400}", Encoding.UTF8, "application/json")
+                    };
+                }
+                if (uri.Contains("query="))
+                {
+                    var searchJson = @"
+                    {
+                        ""data"": {
+                            ""searchUsers"": [
+                                {
+                                    ""id"": ""inst-synthetic-id"",
+                                    ""instinctId"": ""inst-synthetic-id"",
+                                    ""status"": ""Active"",
+                                    ""isActive"": true,
+                                    ""username"": ""jsmith"",
+                                    ""nameFirst"": ""John"",
+                                    ""nameLast"": ""Smith"",
+                                    ""roles"": [
+                                        { ""label"": ""Staff"" }
+                                    ]
+                                }
+                            ]
+                        }
+                    }";
+                    return new HttpResponseMessage(HttpStatusCode.OK)
+                    {
+                        Content = new StringContent(searchJson, Encoding.UTF8, "application/json")
+                    };
+                }
+                return new HttpResponseMessage(HttpStatusCode.NotFound);
+            });
+
+            var httpClientFactory = Substitute.For<IHttpClientFactory>();
+            httpClientFactory.CreateClient(Arg.Any<string>()).Returns(_ => new HttpClient(mockHandler));
+
+            // 3. Setup DbContexts and Seed Synthetic Data
+            var aaudOptions = CreateInMemoryOptions<AAUDContext>();
+            var coursesOptions = CreateInMemoryOptions<CoursesContext>();
+
+            using (var aaudSetup = new AAUDContext(aaudOptions))
+            {
+                var syntheticUser = new AaudUser
+                {
+                    IamId = "99999999",
+                    MothraId = "88888888",
+                    MailId = "jsmith",
+                    LoginId = "jsmith",
+                    FirstName = "John",
+                    LastName = "Smith",
+                    DisplayFirstName = "John",
+                    DisplayLastName = "Smith",
+                    DisplayFullName = "John Smith",
+                    Current = 1,
+                    EmployeeId = "emp-999",
+                    EmployeePKey = "pkey-999",
+                    ClientId = "1"
+                };
+                aaudSetup.AaudUsers.Add(syntheticUser);
+
+                aaudSetup.Employees.Add(new Employee
+                {
+                    EmpPKey = "pkey-999",
+                    EmpTermCode = "202610",
+                    EmpPrimaryTitle = "Synthetic Analyst",
+                    EmpSchoolDivision = "Synthetic Division",
+                    EmpStatus = "A",
+                    EmpHomeDept = "Synthetic Dept",
+                    EmpClientid = "1",
+                    EmpAltDeptCode = "",
+                    EmpCbuc = ""
+                });
+
+                await aaudSetup.SaveChangesAsync(TestContext.Current.CancellationToken);
+            }
+
+            using (var coursesSetup = new CoursesContext(coursesOptions))
+            {
+                coursesSetup.Terminfos.Add(new Terminfo
+                {
+                    TermCode = "202610",
+                    TermCurrentTermMulti = true,
+                    TermAcademicYear = "",
+                    TermDesc = "",
+                    TermCollCode = "01",
+                    TermStartDate = DateTime.Today,
+                    TermEndDate = DateTime.Today,
+                    TermCurrentTerm = true,
+                    TermTermType = ""
+                });
+                await coursesSetup.SaveChangesAsync(TestContext.Current.CancellationToken);
+            }
+
+            using var aaud = new AAUDContext(aaudOptions);
+            using var raps = new RAPSContext(CreateInMemoryOptions<RAPSContext>());
+            using var courses = new CoursesContext(coursesOptions);
+            using var loans = new EquipmentLoanContext(CreateInMemoryOptions<EquipmentLoanContext>());
+            using var pps = new PPSContext(CreateInMemoryOptions<PPSContext>());
+            using var idcards = new IDCardsContext(CreateInMemoryOptions<IDCardsContext>());
+            using var keys = new KeysContext(CreateInMemoryOptions<KeysContext>());
+            using var sis = new SISContext(CreateInMemoryOptions<SISContext>());
+
+            var userInfoService = new UserInfoService(aaud, raps, courses, loans, pps, idcards, keys, sis, config, httpClientFactory, memoryCache, Substitute.For<ILogger<UserInfoService>>());
+
+            // 4. Act
+            // Temporary HttpHelper configuration inside the test context
+            var mockEnv = Substitute.For<Microsoft.AspNetCore.Hosting.IWebHostEnvironment>();
+            HttpHelper.Configure(memoryCache, config, mockEnv, null, null, null);
+
+            UserInfoResult? result;
+            try
+            {
+                result = await userInfoService.GetUserInfoAsync("99999999", "88888888");
+            }
+            finally
+            {
+                HttpHelper.Configure(null, null, null!, null, null, null);
+            }
+
+            // 5. Assert
+            Assert.NotNull(result);
+            _output.WriteLine($"[DEBUG] Result IamId: {result.IamId}");
+            _output.WriteLine($"[DEBUG] Result DisplayName: {result.DisplayFullName}");
+            _output.WriteLine($"[DEBUG] Result InstinctId: {result.InstinctId}");
+            _output.WriteLine($"[DEBUG] Result InstinctInfo.ErrorMessage: {result.InstinctInfo?.ErrorMessage}");
+            _output.WriteLine($"[DEBUG] Result InstinctInfo.Valid: {result.InstinctInfo?.Valid}");
+
+            Assert.Equal("99999999", result.IamId);
+            Assert.Equal("88888888", result.MothraId);
+            Assert.Equal("John Smith", result.DisplayFullName);
+            Assert.True(result.IsEmployee);
+            Assert.Equal("Synthetic Analyst", result.EmployeePrimaryTitle);
+            Assert.Equal("inst-synthetic-id", result.InstinctId);
+            Assert.Equal("jsmith", result.InstinctUsername);
+        }
+
+        private class MockHttpMessageHandler : HttpMessageHandler
+        {
+            private readonly Func<HttpRequestMessage, HttpResponseMessage> _handler;
+
+            public MockHttpMessageHandler(Func<HttpRequestMessage, HttpResponseMessage> handler)
+            {
+                _handler = handler;
+            }
+
+            protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
+            {
+                return Task.FromResult(_handler(request));
+            }
+        }
+    }
+}