feat(internal/idmapper): add ID-mapper package#178
Open
justinwon777 wants to merge 1 commit into
Open
Conversation
liujsj
reviewed
Jul 10, 2026
justinwon777
force-pushed
the
idmap-extract
branch
from
ecc4132 to
5522ee2
Compare
Adds internal/idmapper with NameIDMapper, the stable name->int32 ID assigner used to build the tangopb wire format's ID-keyed maps. This is purely additive: no existing callers are migrated and core/common is untouched, so this package is currently unused. A follow-up PR will switch controller and orchestrator over to it and remove the duplicated code from core/common. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
justinwon777
force-pushed
the
idmap-extract
branch
from
5522ee2 to
a800c77
Compare
justinwon777
changed the title
justinwon777
commented
Jul 11, 2026
|
|
||
| // Package idmapper provides the ID-mapping primitives used to build the tangopb | ||
| // wire format's int32-ID-keyed maps. | ||
| package idmapper |
Contributor
Author
There was a problem hiding this comment.
This maybe should be under internal/mapper/idmapper, but wasn't sure if internal/mapper is supposed to be only for just proto mappers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds internal/idmap with NameIDMapper that today live in core/common. A follow-up PR will switch controller and orchestrator over to it and remove the duplicated code from core/common.
Test Plan
unit test
Issue