Make sure config values are actually being used not defaults

core/common/utils.go

@@ -137,8 +137,11 @@ func HashRequestOptions(opts *tangopb.RequestOptions) string {
 // for typical target rates.
 const cancelCheckInterval = 4096
 
-// ResultToGetTargetGraphResponse converts a Result to a GetTargetGraphResponse
-func ResultToGetTargetGraphResponse(ctx context.Context, result targethasher.Result) ([]*tangopb.GetTargetGraphResponse, error) {
+// ResultToGetTargetGraphResponse converts a Result to a GetTargetGraphResponse.
+// targetChunkSize controls how many OptimizedTarget entries per stream message.
+// metadataMapChunkSize controls how many entries per metadata map chunk.
+// TODO: move this function to internal/mapper
+func ResultToGetTargetGraphResponse(ctx context.Context, result targethasher.Result, targetChunkSize, metadataMapChunkSize int) ([]*tangopb.GetTargetGraphResponse, error) {
 	// Map target names to ids. This list is topologically sorted, so the ids are stable.
 	// IDs start at 1 — 0 is reserved as the proto3 "unset" sentinel so consumers using
 	// encoding/json (which honors `omitempty` on int32 fields) never silently lose a target.
@@ -224,14 +227,14 @@ func ResultToGetTargetGraphResponse(ctx context.Context, result targethasher.Res
 	attrStrValIDToVal := attrStrValMapper.Invert()
 
 	// chunk targets into multiple messages for streaming
-	responses := chunkTargets(optimizedTargets, DefaultTargetChunkSize)
+	responses := chunkTargets(optimizedTargets, targetChunkSize)
 	for _, meta := range ChunkMetadata(
 		targetIDToName,
 		ruleTypeIDToName,
 		tagIDToName,
 		attrNameIDToName,
 		attrStrValIDToVal,
-		DefaultMetadataMapChunkSize,
+		metadataMapChunkSize,
 	) {
 		responses = append(responses, &tangopb.GetTargetGraphResponse{
 			Item: &tangopb.GetTargetGraphResponse_Metadata{Metadata: meta},

core/common/utils_test.go

@@ -186,7 +186,6 @@ func TestChunkTargets(t *testing.T) {
 func TestResultToGetTargetGraphResponse_Chunking(t *testing.T) {
 	t.Parallel()
 
-	// 500 targets with DefaultTargetChunkSize=250 → 2 target chunks + 1 metadata = 3 responses
 	numTargets := 500
 	result := targethasher.Result{
 		TargetNames: make([]string, numTargets),
@@ -198,16 +197,45 @@ func TestResultToGetTargetGraphResponse_Chunking(t *testing.T) {
 		result.Targets[name] = &targethasher.Target{Name: name, Hash: []byte{0}, RuleType: "go_library"}
 	}
 
-	responses, err := ResultToGetTargetGraphResponse(context.Background(), result)
-	require.NoError(t, err)
-
-	// 2 target chunks + 1 metadata chunk (500 targets well under DefaultMetadataMapChunkSize)
-	require.Len(t, responses, 3)
+	tests := []struct {
+		name                 string
+		targetChunkSize      int
+		metadataMapChunkSize int
+		wantTargetChunks     int
+	}{
+		{
+			name:                 "250 per chunk",
+			targetChunkSize:      250,
+			metadataMapChunkSize: 50_000,
+			wantTargetChunks:     2,
+		},
+		{
+			name:                 "100 per chunk",
+			targetChunkSize:      100,
+			metadataMapChunkSize: 50_000,
+			wantTargetChunks:     5,
+		},
+		{
+			name:                 "all in one chunk",
+			targetChunkSize:      1000,
+			metadataMapChunkSize: 50_000,
+			wantTargetChunks:     1,
+		},
+	}
 
-	for _, resp := range responses[:2] {
-		_, ok := resp.Item.(*pb.GetTargetGraphResponse_Targets)
-		assert.True(t, ok, "expected Targets chunk")
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+			responses, err := ResultToGetTargetGraphResponse(context.Background(), result, tt.targetChunkSize, tt.metadataMapChunkSize)
+			require.NoError(t, err)
+
+			var targetChunks int
+			for _, resp := range responses {
+				if _, ok := resp.Item.(*pb.GetTargetGraphResponse_Targets); ok {
+					targetChunks++
+				}
+			}
+			assert.Equal(t, tt.wantTargetChunks, targetChunks)
+		})
 	}
-	_, ok := responses[2].Item.(*pb.GetTargetGraphResponse_Metadata)
-	assert.True(t, ok, "last response should be Metadata")
 }

example/cmd/query-bench/main.go

@@ -112,7 +112,10 @@ func run() error {
 		totalDuration += elapsed
 		fmt.Printf("run %d: targethasher: %v  (%d targets)\n", i+1, elapsed.Round(time.Millisecond), len(targethasherResult.TargetNames))
 		start = time.Now()
-		response, err := common.ResultToGetTargetGraphResponse(ctx, targethasherResult) // also print the time to convert to GetTargetGraphResponse format
+		response, err := common.ResultToGetTargetGraphResponse(
+			ctx, targethasherResult,
+			common.DefaultTargetChunkSize, common.DefaultMetadataMapChunkSize,
+		)
 		if err != nil {
 			return fmt.Errorf("run %d: converting to GetTargetGraphResponse: %w", i+1, err)
 		}

orchestrator/native_orchestrator.go

@@ -206,7 +206,10 @@ func (b *nativeOrchestrator) GetTargetGraph(ctx context.Context, param GetTarget
 	if err != nil {
 		return nil, fmt.Errorf("compute target graph: %w", err)
 	}
-	responses, err := common.ResultToGetTargetGraphResponse(ctx, result)
+	responses, err := common.ResultToGetTargetGraphResponse(ctx, result,
+		b.config.Service.Chunking.TargetChunkSize,
+		b.config.Service.Chunking.MetadataMapChunkSize,
+	)
 	if err != nil {
 		return nil, fmt.Errorf("convert target graph to response: %w", err)
 	}

orchestrator/testdata/config.yaml

@@ -11,3 +11,7 @@ repository:
 
 service:
   worker_pool_size: 3
+  chunking:
+    target_chunk_size: 250
+    changed_target_chunk_size: 125
+    metadata_map_chunk_size: 50000