Skip to content

[WIP] migrate controller to core/errors TangoError#173

Draft
justinwon777 wants to merge 1 commit into
justin.won/errorsfrom
common-migrate
Draft

[WIP] migrate controller to core/errors TangoError#173
justinwon777 wants to merge 1 commit into
justin.won/errorsfrom
common-migrate

Conversation

@justinwon777

@justinwon777 justinwon777 commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Migrate controller and orchestrator from common.ClassifiedError / common.WithReason to core/errors.TangoError

  • controller/errors.go: Replaced emitFailureMetric to use tangoerrors.GetErrorCode / GetFailureSource instead of ClassifiedError. Removed failureReason* constants. Added newControllerInfraError and newControllerUserError helpers.
  • controller/gettargetgraph.go and controller/getchangedtargets.go:
  • RPC deferred blocks now call mapper.ToProtoError(retErr) to convert errors to YARPC responses with TangoError details.
  • Validation errors wrapped with newControllerUserError.
  • Controller-originated infra errors wrapped with newControllerInfraError.
  • Subsystem errors (storage, orchestrator) pass through — classification comes from the subsystem.
  • Removed manual ctx.Err() checks — GetErrorCode and the mapper handle context.Canceled automatically.

Test Plan

unit tests

@justinwon777 justinwon777 requested review from a team as code owners July 10, 2026 08:46
@justinwon777 justinwon777 marked this pull request as draft July 10, 2026 08:49
@justinwon777 justinwon777 changed the title [WIP] refactor: migrate controller and orchestrator to core/errors TangoError [WIP] migrate controller and orchestrator to core/errors TangoError Jul 10, 2026
@justinwon777 justinwon777 changed the title [WIP] migrate controller and orchestrator to core/errors TangoError [WIP] migrate controller to core/errors TangoError Jul 11, 2026
@justinwon777 @claude
refactor(controller): migrate to core/errors TangoError
9844525 
Replace common.ClassifiedError / common.WithReason with core/errors
TangoError in the controller. RPC methods now convert errors via
mapper.ToProtoError in their deferred block, and emitFailureMetric
uses GetErrorCode / GetFailureSource to tag metrics.

Orchestrator and core/common/errors.go are left on the existing
ClassifiedError scheme, to be migrated in a follow-up.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@justinwon777