Ensure all configs are used or checked in the constructor#172
Conversation
| } | ||
| if config.Repository[i].QueryTimeoutSeconds <= 0 { | ||
| return nil, fmt.Errorf("repository[%d].query_timeout_seconds must be > 0", i) | ||
| } |
There was a problem hiding this comment.
Why are we removing the default values and erroring out. Should we not have default values if user do not provide for timeout or chunks?
I am not sure what the config document will look like but initial gut reaction is that we are asking users of the library to be quite knowledgable in the code base vs working out of the box
There was a problem hiding this comment.
Also if we do decide to change that these must be provided, then please update service_config comments as it mentions
// streaming chunk sizes; zero values fall back to package defaults
| mockCmd.EXPECT().Wait().Return(nil), | ||
| ) | ||
| client, err := NewBazelClient(context.Background(), Params{ | ||
| QueryTimeout: 5 * time.Minute, |
There was a problem hiding this comment.
it is better to rely on test timeout rather than hardcode
|
Will update once config rfc is up. Moving change for checking the default values in methods and ensuring they're used in #175 |
3 participants
All config validation is now done in constructors. Methods no longer check for config values. Return a validation error if the config was not set.