feat(stovepipe): advance queue latest_request_id on ingest#323
Merged
Conversation
mnoah1
force-pushed
the
mnoah1/stovepipe-request-entity
branch
from
bbf0abf to
90cbeef
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-ingest-queue-wiring
branch
from
6a281c4 to
b27d20c
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-request-entity
branch
from
90cbeef to
e7aaff3
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-ingest-queue-wiring
branch
from
fee8ec1 to
5f7ab76
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-request-entity
branch
from
e7aaff3 to
6bbe4ad
Compare
Collaborator
|
This PR could not be automatically rebased after its base PR was merged. The rebase hit conflicts that need manual resolution. To fix manually: git fetch origin
git checkout mnoah1/stovepipe-ingest-queue-wiring
git rebase --onto origin/main 6bbe4ad9380e0e0dd8d24b228f93004ee0b08c0d mnoah1/stovepipe-ingest-queue-wiring
# resolve conflicts, then:
git push --force-with-leaseThen update this PR's base branch: gh pr edit 323 --base main |
After ensureRequest succeeds, CAS-update the queue row's latest_request_id when the request id is newer. CompareRequestID makes the advance a no-op on dedup re-ingests; optimistic-lock retries handle concurrent ingests.
Replace the missing QueueStore.GetOrCreate call with ensureQueue, matching the ensureRequest pattern used elsewhere in the ingest controller.
mnoah1
force-pushed
the
mnoah1/stovepipe-ingest-queue-wiring
branch
from
5f7ab76 to
1cb5649
Compare
behinddwalls
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
Test Plan