Skip to content

feat(stovepipe): extend Request entity to support new process step#319

Merged
mnoah1 merged 1 commit into
mainfrom
mnoah1/stovepipe-request-entity
Jul 10, 2026
Merged

feat(stovepipe): extend Request entity to support new process step#319
mnoah1 merged 1 commit into
mainfrom
mnoah1/stovepipe-request-entity

Conversation

@mnoah1

@mnoah1 mnoah1 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

What?

Updating the Request entity to accommodate upcoming functionality in the process step:

  • New RequestState values - processing once the processing step has started, and superseded for requests that will be skipped in favor of building a newer one
  • BuildStrategy/BaseURI fields which will get populated by the process process for downstream use during builds
  • Since request IDs are minted in order by ingest, I realized it's a bit redundant to store a separate sequence ID in the DB. Instead, define a CompareRequestID function for cases that require ID comparison, and converge to just storing the ID.

Why?

Implementing behavior in https://github.com/uber/submitqueue/blob/main/doc/rfc/stovepipe/steps/process.md - which introduces two new outcome states and includes logic to determine the build strategy for a request.

Test Plan

  • Unit tests
  • Subsequent changes will pull this logic together into an end to end flow

@mnoah1 mnoah1 marked this pull request as ready for review July 8, 2026 21:19
@mnoah1 mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners July 8, 2026 21:19
@mnoah1 mnoah1 changed the title feat(stovepipe): extend Request entity and MySQL storage feat(stovepipe): extend Request entity to support new process step Jul 8, 2026
Comment thread stovepipe/entity/request.go Outdated
Comment thread stovepipe/entity/request.go
Comment thread stovepipe/entity/request_id.go
@mnoah1 mnoah1 force-pushed the mnoah1/stovepipe-request-entity branch from bbf0abf to 90cbeef Compare July 9, 2026 18:20
@behinddwalls

Copy link
Copy Markdown
Collaborator

🛑 Automatic stack rebase aborted — diff mismatch

The rebase of mnoah1/stovepipe-request-entity completed without conflicts, but the resulting code diff does not match the original. This means the rebase silently altered code content. The branch was not force-pushed.

Please rebase manually and verify the changes are correct.

@mnoah1 mnoah1 force-pushed the mnoah1/stovepipe-request-entity branch from 90cbeef to e7aaff3 Compare July 10, 2026 18:08
@mnoah1 mnoah1 changed the base branch from mnoah1/stovepipe-queue-store to main July 10, 2026 18:10
@mnoah1 mnoah1 enabled auto-merge July 10, 2026 18:11
@mnoah1 mnoah1 force-pushed the mnoah1/stovepipe-request-entity branch from e7aaff3 to 6bbe4ad Compare July 10, 2026 18:41
@mnoah1 mnoah1 added this pull request to the merge queue Jul 10, 2026
Merged via the queue into main with commit 6e2fa6e Jul 10, 2026
15 checks passed
@mnoah1 mnoah1 deleted the mnoah1/stovepipe-request-entity branch July 10, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants