fix(sensor): close Cursor SQLite connections - #87
Draft
barisozbas wants to merge 1 commit into
Draft
Conversation
Summary: Intent: - Release Cursor database resources reliably after parsing. Changes: - Close connections on success and failure paths. - Verify closure against a real temporary SQLite database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Cursor SQLite connections are now closed deterministically after parsing.
Why
Leaked read connections can retain file descriptors and database locks across repeated collection runs.
Validation
pytest -q Sensor/testsruff check Sensor/adr_sensor/parsers/cursor_parser.py Sensor/tests/test_parsers.py