Clean up diff update temporary resources - #34070
Open
luojiyin1987 wants to merge 1 commit into
Open
Conversation
3 tasks
luojiyin1987
marked this pull request as ready for review
August 11, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #34067.
Summary
Register an EXIT trap for temporary files and clone directories.
Track every path returned by mktemp.
Remove the normal-path file cleanup at the end.
Root cause
The script only removed its two files after the loop completed.
Failures and interruptions could bypass those commands.
A failed clone also skipped the existing directory cleanup.
Impact
The script removes temporary files on every exit path.
It also removes directories from failed clone attempts.
Diff patch generation behavior stays unchanged.
Checks