cleanup(Inserter): switch from java.sql.Connection to foundations Connection - #45
Merged
Merged
Conversation
…nection Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
oyvindberg
force-pushed
the
cleanup/inserter-connection-import
branch
from
May 2, 2026 11:43
df315eb to
c94bca6
Compare
oyvindberg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inserternow takes the foundationsConnection(same package) instead ofjava.sql.Connection, matching the rest of the API.Test plan
bleep compile foundations-jdbc foundations-jdbc-hikari foundations-jdbc-spring foundations-jdbc-kotlin foundations-jdbc-scalapasses🤖 Generated with Claude Code