Skip to content

Improve provenance - #7912

Merged
smillst merged 90 commits into
typetools:masterfrom
mernst:type-inference-8-review-2-16
Aug 10, 2026
Merged

Improve provenance#7912
smillst merged 90 commits into
typetools:masterfrom
mernst:type-inference-8-review-2-16

Conversation

@mernst

@mernst mernst commented Aug 4, 2026

Copy link
Copy Markdown
Member

Merge #7941 first.

mernst added 30 commits July 25, 2026 13:21

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@checker/jtreg/nullness/defaultsPersist/ReferenceInfoUtil.java`:
- Around line 110-112: Remove the System.out.println debug statement inside the
properName.equals(actualName) condition in ReferenceInfoUtil, leaving the
name-matching logic and existing ComparisonException reporting unchanged.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 57914c6e-5269-40b2-98f9-1e4a74f5277b

📥 Commits

Reviewing files that changed from the base of the PR and between 16f005f and ea36577.

📒 Files selected for processing (16)
  • build.gradle
  • checker/jtreg/nullness/PersistUtil.java
  • checker/jtreg/nullness/defaultsPersist/Classes.java
  • checker/jtreg/nullness/defaultsPersist/Constructors.java
  • checker/jtreg/nullness/defaultsPersist/Driver.java
  • checker/jtreg/nullness/defaultsPersist/Fields.java
  • checker/jtreg/nullness/defaultsPersist/Methods.java
  • checker/jtreg/nullness/defaultsPersist/ReferenceInfoUtil.java
  • checker/jtreg/nullness/inheritDeclAnnoPersist/Driver.java
  • checker/jtreg/nullness/inheritDeclAnnoPersist/Extends.java
  • checker/jtreg/nullness/inheritDeclAnnoPersist/Implements.java
  • checker/jtreg/nullness/inheritDeclAnnoPersist/ReferenceInfoUtil.java
  • framework-test/src/main/java/org/checkerframework/framework/test/TestUtilities.java
  • framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/TestDiagnosticUtils.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/constraint/TypeConstraint.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/VariableBounds.java

Comment thread checker/jtreg/nullness/defaultsPersist/ReferenceInfoUtil.java
@smillst smillst mentioned this pull request Aug 7, 2026
@smillst
smillst merged commit 4c616d0 into typetools:master Aug 10, 2026
21 checks passed
@smillst
smillst deleted the type-inference-8-review-2-16 branch August 10, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants