Skip to content

test(server): add tests showing what artifacts are prefetched #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krzema12 merged 1 commit into from
Jun 5, 2026
+60 −7
Merged

test(server): add tests showing what artifacts are prefetched #2334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 60 additions & 7 deletions .../test/kotlin/io/github/typesafegithub/workflows/mavenbinding/MavenMetadataBuildingTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@ import io.github.typesafegithub.workflows.actionbindinggenerator.domain.Signific
import io.github.typesafegithub.workflows.actionbindinggenerator.domain.SignificantVersion.FULL
import io.github.typesafegithub.workflows.shared.internal.model.Version
import io.kotest.core.spec.style.FunSpec
import io.kotest.matchers.collections.shouldContainExactlyInAnyOrder
import io.kotest.matchers.nulls.shouldBeNull
import io.kotest.matchers.nulls.shouldNotBeNull
import io.kotest.matchers.shouldBe
import io.kotest.matchers.shouldNotBe
import io.micrometer.core.instrument.MeterRegistry
import java.time.ZonedDateTime

Expand Down Expand Up @@ -47,10 +50,14 @@ class MavenMetadataBuildingTest :
).right()
}

var prefetchedCoords: Collection<ActionCoords>? = null
val xml =
bindingsServerRequest.buildMavenMetadataFile(
githubAuthToken = "SOME_TOKEN",
fetchAvailableVersions = fetchAvailableVersions,
prefetchBindingArtifacts = {
prefetchedCoords = it
},
)

xml shouldBe
Expand All @@ -70,6 +77,19 @@ class MavenMetadataBuildingTest :
</versioning>
</metadata>
""".trimIndent()

prefetchedCoords shouldNotBe null
prefetchedCoords shouldContainExactlyInAnyOrder
listOf(
bindingsServerRequest.actionCoords.copy(
version = "v1",
versionForTypings = "irrelevant",
),
bindingsServerRequest.actionCoords.copy(
version = "v2",
versionForTypings = "irrelevant",
),
)
}

test("no major versions") {
Expand All @@ -89,13 +109,21 @@ class MavenMetadataBuildingTest :
).right()
}

var prefetchedCoords: Collection<ActionCoords>? = null
val xml =
bindingsServerRequest.buildMavenMetadataFile(
githubAuthToken = "SOME_TOKEN",
fetchAvailableVersions = fetchAvailableVersions,
prefetchBindingArtifacts = {
prefetchedCoords = it
},
)

xml.shouldBeNull()

prefetchedCoords shouldNotBeNull {
size shouldBe 0
}
}

test("no versions available") {
Expand All @@ -109,24 +137,27 @@ class MavenMetadataBuildingTest :
emptyList<Version>().right()
}

var prefetchedCoords: Collection<ActionCoords>? = null
val xml =
bindingsServerRequest.buildMavenMetadataFile(
githubAuthToken = "SOME_TOKEN",
fetchAvailableVersions = fetchAvailableVersions,
prefetchBindingArtifacts = {
prefetchedCoords = it
},
)

xml.shouldBeNull()

prefetchedCoords shouldNotBeNull {
size shouldBe 0
}
}

(SignificantVersion.entries - FULL).forEach { significantVersion ->
test("significant version $significantVersion requested") {
// Given
val fetchAvailableVersions: suspend (
String,
String,
String?,
MeterRegistry?,
) -> Either<String, List<Version>> = { owner, name, _, _ ->
var availableVersions =
listOf(
Version(
version = "v3-beta",
Expand Down Expand Up @@ -168,9 +199,17 @@ class MavenMetadataBuildingTest :
shaProvider = { "8" },
dateProvider = { ZonedDateTime.parse("2024-03-01T00:00:00Z") },
),
).right()
)
val fetchAvailableVersions: suspend (
String,
String,
String?,
MeterRegistry?,
) -> Either<String, List<Version>> = { owner, name, _, _ ->
availableVersions.right()
}

var prefetchedCoords: Collection<ActionCoords>? = null
val xml =
bindingsServerRequest
.copy(
Expand All @@ -182,6 +221,9 @@ class MavenMetadataBuildingTest :
).buildMavenMetadataFile(
githubAuthToken = "SOME_TOKEN",
fetchAvailableVersions = fetchAvailableVersions,
prefetchBindingArtifacts = {
prefetchedCoords = it
},
)

val commitLenient = significantVersion == COMMIT_LENIENT
Expand All @@ -208,6 +250,17 @@ class MavenMetadataBuildingTest :
</versioning>
</metadata>
""".trimIndent()

prefetchedCoords shouldNotBe null
prefetchedCoords shouldContainExactlyInAnyOrder
availableVersions.map { availableVersion ->
bindingsServerRequest.actionCoords.copy(
version = "$availableVersion",
comment = null,
significantVersion = significantVersion,
versionForTypings = "irrelevant",
)
}
}
}
})
Loading