Replace target references with declared state paths - #226
Merged
Merged
Conversation
Transitions, initial edges, history, owner updates, and named branches take dotted path strings checked against the root passed to make. The root is spelled "root", and `initialize` reconstructs it from fresh machine input, replacing root targets and Machine.targets. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Type performanceMeasured with TypeScript 6.0.3 and
Marginal instantiations are measured against the matching setup without that API call:
Check times (informational)
Type instantiations are the comparison metric. Check time varies with runner load and is informational only. |
Contributor
Runtime performanceMedian of 5 independent benchmark processes on Pull request baseline
Process runtime reference points
Effect Machine change from base
Process runtime reference change from base
Regression guardNo large, noise-adjusted throughput or heap regressions detected. Versions and interpretation
Higher throughput is better; lower heap is better. Variability is the median absolute deviation across independent processes, relative to their median. Small differences on shared GitHub-hosted hardware remain informational; the required guard rejects only large changes beyond the measured noise allowance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Checkout.Review") instead ofMachine.targets(Root)references. Paths are spelled like snapshot paths, checked against the root passed tomake, and completed by the editor.Machine.targets,Targets, andTargetReferenceare removed."root"(e.g.update: "root"), so a top-level state namedrootis rejected at compile time and whenmakecaptures the definition. The root is not a destination.initializereplaces{ target: root, input }for reconstructing root from fresh machine input: a value or callback for machines with input,trueotherwise. Branch declarations use{ initialize: true }withselect.branch({ input }). This also fixes reconstructing an input-less machine, which previously crashed while decoding a missing input schema.target: "root", and invalidinitializecombinations.no-async-planning-callbackalso checksinitializemappers. The runtime-benchmark compatibility layer supports both the reference and path APIs through a capability probe.rootnow usemain. NewPathsruntime and type tests plus a forced generic-versus-optimized differential case cover input-less root initialization.Trade-off: a declaration stored in a variable before it reaches
makeor.handleneedsas constso its paths stay literal. This is documented in the README and in the changeset.Changeset
Minor for
@typeonce/effect-machine, with direct migration steps. Patch for devtools and the oxlint plugin. Removedtargetsfrom the pendingtyped-operation-boundarychangeset, since this release removes it.Validation
pnpm checkLocal
pnpm perf:typesandpnpm perf:runtimepassed within the configured budgets. The CI base-versus-PR comparisons are authoritative.🤖 Generated with Claude Code