Add scalafix rules for 0.13.0 release#330
Merged
Merged
Conversation
zainab-ali
force-pushed
the
scalafix-0.13.0
branch
from
696955c to
6674f74
Compare
zainab-ali
force-pushed
the
scalafix-0.13.0
branch
from
6674f74 to
4dc7fcb
Compare
majk-p
approved these changes
Jun 1, 2026
| def basicFunction(suite: FunSuite): FunSuite = suite | ||
| } | ||
|
|
||
| import weaver.{ FunSuite => FunSuiteIOAlias } |
Contributor
There was a problem hiding this comment.
Nit: how about removing IO from the alias?
Suggested change
| import weaver.{ FunSuite => FunSuiteIOAlias } | |
| import weaver.{ FunSuite => FunSuiteAlias } |
Collaborator
Author
There was a problem hiding this comment.
I think it would be better to leave it untouched. We can't guarantee what the alias name is, nor whether it will conflict with anything else in the user code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
0.13.0rule addresses the renames in #318 and #317.This can be added to scala-steward via this config change.
Note that the
0.11.xand0.9.xrule tests fail due to incorrectly applied formatting. scalafmt upgrades don't seem to respect our excludePaths. This can be addressed in #331 .