Tab: ignore modifier+arrow shortcuts; docs: menu Escape behavior#42553
Open
mdo wants to merge 3 commits into
Open
Tab: ignore modifier+arrow shortcuts; docs: menu Escape behavior#42553mdo wants to merge 3 commits into
mdo wants to merge 3 commits into
Conversation
_keydown preventDefault'd arrow keys regardless of modifiers, so Alt+Left/Right (browser history nav) and similar shortcuts were swallowed inside a tablist. Ignore the event when alt/ctrl/meta is held. Fixes #38565.
Esc closes the menu while focus is within it (regardless of autoClose) and returns focus to the toggle. Fixes #38035.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes:
_keydowncalledpreventDefault()on arrow keys regardless of modifiers, so Alt+Left/Right (browser history) and similar were swallowed inside a tablist. Ignore the event when alt/ctrl/meta is held. Fixes nav-link tabs are preventing default browser behavior for alt + left/right arrow keys #38565. (unit test added, verified to fail without the fix)autoClose) and returns focus to the toggle. Fixes BDropdown autoClose false description inaccurate to actual behavior #38035.Full suite passes; eslint + markdownlint + prettier clean.