Skip to content

Expose FromValue trait without Sealed implementation #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nathanfaucett wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −19
Draft

Expose FromValue trait without Sealed implementation #2253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libsql/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ pub use self::{
connection::{AuthHook, BatchRows, Connection, Op},
database::{Builder, Database},
load_extension_guard::LoadExtensionGuard,
rows::{Column, Row, Rows},
rows::{Column, FromValue, Row, Rows},
statement::Statement,
transaction::{Transaction, TransactionBehavior},
};
Expand Down
19 changes: 1 addition & 18 deletions libsql/src/rows.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ impl fmt::Debug for Row {
}

/// Convert a `Value` into the implementors type.
pub trait FromValue: Sealed {
pub trait FromValue {
fn from_sql(val: Value) -> Result<Self>
where
Self: Sized;
Expand All @@ -164,7 +164,6 @@ impl FromValue for crate::Value {
Ok(val)
}
}
impl Sealed for crate::Value {}

impl FromValue for i32 {
fn from_sql(val: Value) -> Result<Self> {
Expand All @@ -175,7 +174,6 @@ impl FromValue for i32 {
}
}
}
impl Sealed for i32 {}

impl FromValue for u32 {
fn from_sql(val: Value) -> Result<Self> {
Expand All @@ -186,7 +184,6 @@ impl FromValue for u32 {
}
}
}
impl Sealed for u32 {}

impl FromValue for i64 {
fn from_sql(val: Value) -> Result<Self> {
Expand All @@ -197,7 +194,6 @@ impl FromValue for i64 {
}
}
}
impl Sealed for i64 {}

impl FromValue for u64 {
fn from_sql(val: Value) -> Result<Self> {
Expand All @@ -208,7 +204,6 @@ impl FromValue for u64 {
}
}
}
impl Sealed for u64 {}

impl FromValue for f64 {
fn from_sql(val: Value) -> Result<Self> {
Expand All @@ -219,7 +214,6 @@ impl FromValue for f64 {
}
}
}
impl Sealed for f64 {}

impl FromValue for Vec<u8> {
fn from_sql(val: Value) -> Result<Self> {
Expand All @@ -230,7 +224,6 @@ impl FromValue for Vec<u8> {
}
}
}
impl Sealed for Vec<u8> {}

impl<const N: usize> FromValue for [u8; N] {
fn from_sql(val: Value) -> Result<Self> {
Expand All @@ -243,7 +236,6 @@ impl<const N: usize> FromValue for [u8; N] {
}
}
}
impl<const N: usize> Sealed for [u8; N] {}

impl FromValue for String {
fn from_sql(val: Value) -> Result<Self> {
Expand All @@ -254,7 +246,6 @@ impl FromValue for String {
}
}
}
impl Sealed for String {}

impl FromValue for bool {
fn from_sql(val: Value) -> Result<Self> {
Expand All @@ -269,7 +260,6 @@ impl FromValue for bool {
}
}
}
impl Sealed for bool {}

impl<T> FromValue for Option<T>
where
Expand All @@ -282,7 +272,6 @@ where
}
}
}
impl<T> Sealed for Option<T> {}

pub(crate) trait ColumnsInner {
fn column_name(&self, idx: i32) -> Option<&str>;
Expand All @@ -294,9 +283,3 @@ pub(crate) trait RowInner: ColumnsInner + fmt::Debug {
fn column_value(&self, idx: i32) -> Result<Value>;
fn column_str(&self, idx: i32) -> Result<&str>;
}

mod sealed {
pub trait Sealed {}
}

use sealed::Sealed;
Loading