Skip to content

Enforce string literal use in NOB_SVLIT_STATIC() and NOB_SVLIT() #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
usfbih8u wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enforce string literal use in NOB_SVLIT_STATIC() and NOB_SVLIT() #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nob.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,11 +947,11 @@ NOBDEF Nob_String_View nob_sv_from_parts(const char *data, size_t count);
// nob_sb_to_sv() enables you to just view Nob_String_Builder as Nob_String_View
#define nob_sb_to_sv(sb) nob_sv_from_parts((sb).items, (sb).count)

#define NOB_SVLIT(lit) (NOB_CLIT(Nob_String_View){.count = sizeof(lit)-1, .data = (lit)})
#define NOB_SVLIT(lit) (NOB_CLIT(Nob_String_View){.count = sizeof("" lit "")-1, .data = (lit)})
// Generally majority of the C/C++ compilers will allow you to use NOB_SVLIT to construct global variables.
// But there are some (specifically MSVC with /TC flag enabled) that will refuse.
// For such compilers use NOB_SVLIT_STATIC instead.
#define NOB_SVLIT_STATIC(lit) {.count = sizeof(lit)-1, .data = (lit)}
#define NOB_SVLIT_STATIC(lit) {.count = sizeof("" lit "")-1, .data = (lit)}

// printf macros for String_View
#ifndef SV_Fmt
Expand Down