Conversation
The role MultiRoleCombobox is a Radix Popover portaled to <body> while
rendered inside the modal "Add User" Radix Dialog. The Dialog locks
`body { pointer-events: none }`. A Radix version skew — react-dialog pulls
react-dismissable-layer@1.1.15 while react-popover pins @1.1.11 — puts the
two in separate module-level layer contexts, so the popover never
re-enables pointer events on itself and its role items inherit `none`.
Result: no role (built-in or custom) can be hovered or clicked; only CSV
import worked.
Force pointer-events on the popover content so the whole subtree stays
interactive despite the body lock. Verified in a real browser against the
actual installed Radix packages, and covered by tests for the built-in and
custom-role selection paths.
…r-events fix(people): keep role picker clickable in the invite dialog (CS-748)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
|
🎉 This PR is included in version 3.103.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Fixes the unclickable role picker in the “Add User” dialog by forcing the popover content to accept pointer events, so users can select both built-in and custom roles. Addresses Linear CS-748.
style={{ pointerEvents: 'auto' }}on the popover content to overridebody { pointer-events: none }from@radix-ui/react-dialog.@radix-ui/react-popoverand@radix-ui/react-dialogdue to@radix-ui/react-dismissable-layerversion skew.Written for commit aed9b45. Summary will update on new commits.