Conversation
apps/mcp-server is a public npm-published package (@trycompai/mcp-server) with only npm-public dependencies (@modelcontextprotocol/sdk, express, zod, @stricli/core). It doesn't import any @trycompai/* workspace packages, so it doesn't need workspace membership. WHY THIS IS NECESSARY: Speakeasy's CI publish flow runs `npm install --ignore-scripts` inside apps/mcp-server. With apps/mcp-server as a workspace member, npm walks up to the root package.json, sees the `workspace:*` references in packages/auth, packages/billing, etc., and fails with EUNSUPPORTEDPROTOCOL (npm doesn't understand bun's workspace: protocol). Without the workspace context, npm only reads apps/mcp-server/package.json (which uses only normal semver versions) and installs cleanly. LOCAL DEV IMPACT: Devs working on apps/mcp-server directly will need to run `cd apps/mcp-server && bun install` once to install its dependencies. Other apps and packages are unaffected. In practice apps/mcp-server is regenerated by Speakeasy (`speakeasy run`) rather than hand-edited, so this is a rare workflow. Fixes the publish workflow failure in run 26596920929 and the generate workflow failure in run 26597302360. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…rkspaces fix(monorepo): exclude apps/mcp-server from bun workspaces
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR #2950 enumerated workspaces explicitly to exclude apps/mcp-server, but that broke the API's Docker build: error: Workspace not found "apps/app" error: Workspace not found "apps/framework-editor" error: Workspace not found "apps/portal" The Dockerfile only COPYs apps/api into the build context, so when bun reads package.json and tries to find the other named apps, it fails. The original "apps/*" glob worked because globs only match what exists; explicit paths require the path to exist. Fix: combine glob with negation — ["apps/*", "!apps/mcp-server", "packages/*"] Verified locally: - bun install at root succeeds - node_modules/@trycompai/mcp-server is NOT created - bun.lock has zero references to apps/mcp-server - Original Docker-friendly glob behavior preserved (matches only existing paths) This unbreaks the API Docker build that PR #2950 broke, while still keeping apps/mcp-server outside the bun workspace so Speakeasy's CI npm install doesn't choke on workspace:* protocol. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
fix(monorepo): unbreak Docker build (workspaces glob+negation)
Contributor
|
🎉 This PR is included in version 3.65.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Deploys the latest release to production. Fixes monorepo workspaces with glob+negation to exclude
apps/mcp-server, unblockingnpmpublish and preserving Docker builds.Bug Fixes
workspacesto["apps/*", "!apps/mcp-server", "packages/*"]soapps/mcp-serveris outside thebunworkspace;npm install --ignore-scriptsworks and API Docker builds no longer fail on missing workspaces.Migration
apps/mcp-server, runcd apps/mcp-server && bun installonce.Written for commit ae6cdff. Summary will update on new commits.
Review in cubic