Skip to content

[comp] Production Deploy#2502

Merged
Marfuen merged 4 commits intoreleasefrom
main
Apr 10, 2026
Merged

[comp] Production Deploy#2502
Marfuen merged 4 commits intoreleasefrom
main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.

github-actions bot and others added 2 commits April 10, 2026 17:02
)

- Remove Geist font @font-face from all 12 email templates. Email
  clients block external fonts anyway, and the references created
  unnecessary connections to app.trycomp.ai from email context.
- Delete waitlist.tsx template and lib (dead code, no longer used)
- Clean up barrel exports in packages/email/index.ts

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app (staging) Ready Ready Preview, Comment Apr 10, 2026 6:36pm
comp-framework-editor Ready Ready Preview, Comment Apr 10, 2026 6:36pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal (staging) Skipped Skipped Apr 10, 2026 6:36pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 10, 2026

PR Summary

Medium Risk
Changes compliance logic and UI to merge device-agent and Fleet sources into a single per-member status, which could affect what admins see and which actions (e.g. Remove Device) become available. Also removes Trigger.dev env var syncing and deletes waitlist email functionality, which may impact deploy/runtime behavior if anything still depended on them.

Overview
People → Devices compliance is now unified across the UI. The member list switches from a boolean hasDeviceAgentDevice to a tri-state deviceStatus (compliant/non-compliant/not-installed), updates dot/color/text rendering, and adjusts when Remove Device is offered.

On PeoplePage, a deviceStatusMap is computed from device-agent + (filtered) Fleet host data (agent takes priority; per-member compliance is aggregated across multiple devices) and passed through TeamMembers/TeamMembersClient. The devices compliance chart is updated to accept both agentDevices and fleetDevices and count compliance across both sources; new unit tests cover the chart and member-row status rendering.

Separately, Trigger.dev configs drop syncVercelEnvVars(), email templates remove embedded Font/head blocks, and the waitlist email template + sender exports are deleted.

Reviewed by Cursor Bugbot for commit 56c67df. Bugbot is set up for automated code reviews on this repo. Configure here.

…in people tab

* fix(app): check FleetDM device compliance alongside new device agent

The people tab DEVICE column previously only checked the new device
agent. Now it also checks FleetDM (legacy) so members using either
agent show correct compliance status: Compliant, Non-Compliant, or
Not Installed. Device agent takes priority when both are present.

The devices tab compliance chart now includes both sources in its
totals.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(app): unify device compliance logic between member list and chart

Move device status computation from TeamMembers into page.tsx where
fleet host data (with Fleet API automated checks + DB manual overrides)
is already fetched. This ensures the member list DEVICE column and
the compliance chart use identical data and compliance logic.

Previously TeamMembers only checked FleetPolicyResult DB records,
missing Fleet API automated policy checks. A device passing Fleet's
automated check but lacking a DB override would show "Non-Compliant"
in the member list but "Compliant" in the chart.

Also fixes a bug where multiple fleet devices for the same member
could not downgrade status from compliant to non-compliant.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Trigger.dev manages its own env vars independently.
All required vars are already set in Trigger's dashboard
for both staging and production.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
@vercel vercel bot temporarily deployed to staging – portal April 10, 2026 18:34 Inactive
@Marfuen Marfuen merged commit 980bcb1 into release Apr 10, 2026
13 checks passed
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.20.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants