Skip to content

fix: consume the async exit exception left in EG at request shutdown #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EdmondDantes wants to merge 1 commit into from
Closed

fix: consume the async exit exception left in EG at request shutdown #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions main/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1988,6 +1988,14 @@ void php_request_shutdown(void *dummy)
// control is passed to the coroutines one last time (if any remain).
zend_try {
ZEND_ASYNC_RUN_SCHEDULER_AFTER_MAIN(false);

// The final scheduler pass can finalize the main coroutine here and rethrow its exit
// exception into EG(exception) -- this happens when the entrypoint (e.g. `php -r`) did not
// drive the coroutine to completion itself. With no caller left to handle it, report and
// release it, exactly as php_execute_script() does for the in-script path.
if (UNEXPECTED(EG(exception))) {
zend_exception_error(EG(exception), E_ERROR);
}
} zend_end_try();

// Detach async IO from all streams (they become sync-only).
Expand Down
Loading