Skip to content

Optimize: Modify cls log module#8

Open
raychen911 wants to merge 1 commit into
trpc-ecosystem:mainfrom
raychen911:refactor/raylchen_cls_log
Open

Optimize: Modify cls log module#8
raychen911 wants to merge 1 commit into
trpc-ecosystem:mainfrom
raychen911:refactor/raylchen_cls_log

Conversation

@raychen911

Copy link
Copy Markdown

No description provided.

@github-actions

Copy link
Copy Markdown

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


raylchen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@raychen911 raychen911 force-pushed the refactor/raylchen_cls_log branch from 5612cda to 028fad4 Compare November 20, 2023 06:50
@codecov

codecov Bot commented Nov 20, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.29%. Comparing base (685c238) to head (028fad4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
trpc/logging/cls/cls_log_api.cc 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   70.00%   75.29%   +5.29%     
==========================================
  Files           8        8              
  Lines         170      170              
==========================================
+ Hits          119      128       +9     
+ Misses         51       42       -9     
Files with missing lines Coverage Δ
trpc/logging/cls/cls_log.cc 70.83% <100.00%> (ø)
trpc/logging/cls/cls_log.h 100.00% <100.00%> (ø)
trpc/logging/cls/cls_log_api.cc 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant