Repository navigation
fix(vm): add missing CommonParameter import - #7017
Closed
Federico2014 wants to merge 1 commit into
Closed
Federico2014 wants to merge 1 commit into
Federico2014 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the missing
org.tron.common.parameter.CommonParameterimport inPrecompiledContracts.java.Why are these changes required?
BN128Pairing.pairingDeadlineNs()referencesCommonParameterwithout importing it, causing:actuator:compileJavato fail and blocking Checkstyle, CodeQL, and single-node integration CI onrelease_v4.8.3.This PR has been tested by:
git diff --checkpassed../gradlew :actuator:compileJavaon macOS x86_64 / JDK 8; blocked before actuator compilation by missing types referenced inprotocol/src/main/java/org/tron/api/WalletExtensionGrpc.java.Follow up
Rerun the affected CI workflows after applying the fix.
Extra details
The change adds one import and does not alter runtime logic.