Forward custom HTTP headers on coordinator spooling requests#620
Merged
Merged
Conversation
Spooled segment data-fetch and acknowledge requests were sent through an unauthenticated client that dropped the custom http_headers supplied to connect(). When the coordinator sits behind a proxy that requires those headers (e.g. an auth gateway) the acknowledge request to the coordinator was rejected with "invalid token". Forward the user-supplied custom headers on spooling requests but only when the target URI host matches the coordinator so external storage (e.g. S3 presigned URLs) is left untouched. The per-segment protocol headers returned by the coordinator always take precedence.
wendigo
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spooled segment data-fetch and acknowledge requests were sent through an unauthenticated client that dropped the custom http_headers supplied to connect(). When the coordinator sits behind a proxy that requires those headers (e.g. an auth gateway) the acknowledge request to the coordinator was rejected with "invalid token".
Forward the user-supplied custom headers on spooling requests but only when the target URI host matches the coordinator so external storage (e.g. S3 presigned URLs) is left untouched. The per-segment protocol headers returned by the coordinator always take precedence.
Non-technical explanation
Forward custom HTTP headers on coordinator spooling requests. Fixes #582
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: