Send Content-Type charset on statement POST requests#619
Open
hashhar wants to merge 1 commit into
Open
Conversation
Send "text/plain; charset=utf-8" on the statement POST matching the Trino JDBC client (StatementClientV1). The header is set only on POST and uses setdefault so a user-supplied Content-Type still takes precedence. The client posted the SQL body to /v1/statement without a Content-Type header so no charset was advertised. This breaks Trino Gateway's request analyzer which needs the charset to parse the SQL body for routing rules (it logs "charset is not set in the request" and leaves catalogs/tables/body empty).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Send "text/plain; charset=utf-8" on the statement POST matching the Trino JDBC client (StatementClientV1). The header is set only on POST and uses setdefault so a user-supplied Content-Type still takes precedence.
The client posted the SQL body to /v1/statement without a Content-Type header so no charset was advertised. This breaks Trino Gateway's request analyzer which needs the charset to parse the SQL body for routing rules (it logs "charset is not set in the request" and leaves catalogs/tables/body empty).
Non-technical explanation
Fixes #600
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: