feat(cli,webapp): allow deploys with environment API keys - #4561
Draft
carderne wants to merge 2 commits into
Draft
feat(cli,webapp): allow deploys with environment API keys#4561carderne wants to merge 2 commits into
carderne wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 74249ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (25)
🧰 Additional context used📓 Path-based instructions (11)**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
{packages/core,apps/webapp}/**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{test,spec}.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.ts📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
Files:
apps/webapp/**/*.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Files:
apps/webapp/**/*.test.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Files:
apps/**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/webapp/**/*.{test,spec}.{ts,tsx}📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Files:
apps/webapp/app/**/*.{ts,tsx}📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Files:
apps/webapp/app/**/*.ts📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Files:
🧠 Learnings (20)📚 Learning: 2026-03-22T13:26:12.060ZApplied to files:
📚 Learning: 2026-03-22T19:24:14.403ZApplied to files:
📚 Learning: 2026-05-18T08:21:27.694ZApplied to files:
📚 Learning: 2026-05-18T08:21:27.694ZApplied to files:
📚 Learning: 2026-06-13T19:53:13.759ZApplied to files:
📚 Learning: 2026-06-17T17:13:49.929ZApplied to files:
📚 Learning: 2026-06-23T13:04:21.413ZApplied to files:
📚 Learning: 2026-05-07T12:25:18.271ZApplied to files:
📚 Learning: 2026-05-28T20:02:10.647ZApplied to files:
📚 Learning: 2026-07-30T18:43:56.874ZApplied to files:
📚 Learning: 2026-08-08T12:49:17.489ZApplied to files:
📚 Learning: 2026-05-12T21:04:05.815ZApplied to files:
📚 Learning: 2026-06-25T18:21:51.905ZApplied to files:
📚 Learning: 2026-07-03T17:10:21.498ZApplied to files:
📚 Learning: 2026-05-18T14:40:02.173ZApplied to files:
📚 Learning: 2026-06-04T18:16:35.386ZApplied to files:
📚 Learning: 2026-06-09T17:58:04.699ZApplied to files:
📚 Learning: 2026-06-16T09:19:47.637ZApplied to files:
📚 Learning: 2026-03-26T09:02:07.973ZApplied to files:
📚 Learning: 2026-05-05T09:38:02.512ZApplied to files:
🔇 Additional comments (4)
WalkthroughThe change adds shared bearer-authentication options with preview-parent support. The webapp adds private API-key and project-environment bootstrap authentication. Branch creation accepts scoped API keys and enforces project, environment, and branch restrictions. API-key scopes now include preview branches. The CLI supports 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 93030d01-de1f-443f-b606-b23312c1730b
📒 Files selected for processing (20)
.changeset/deploy-api-keys.mdapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/app/services/authTelemetry.server.tsapps/webapp/app/services/environmentVariableApiAccess.server.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.tsapps/webapp/test/rbacFallbackBranch.test.tsinternal-packages/rbac/src/bearerCredentials.tsinternal-packages/rbac/src/fallback.tsinternal-packages/rbac/src/index.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/commands/preview.tspackages/cli-v3/src/deploy/auth.test.tspackages/cli-v3/src/deploy/auth.tspackages/plugins/src/index.tspackages/plugins/src/rbac.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (28)
- GitHub Check: report
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
- GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - pnpm)
- GitHub Check: typecheck / typecheck
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - npm)
- GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
- GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
- GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
- GitHub Check: runops-guard / runops-guard
- GitHub Check: obsmap / 🧪 Unit Tests: Observability Map
- GitHub Check: internal / 🧪 Unit Tests: Internal
- GitHub Check: code-quality / code-quality
- GitHub Check: 🛡️ E2E Auth Tests (full)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Build and publish previews
🧰 Additional context used
📓 Path-based instructions (17)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
**/*.{ts,tsx}: Prefer static imports over dynamicimport(); use dynamic imports only for unresolvable circular dependencies, genuine performance code splitting, or conditional runtime loading.
Import Trigger.dev tasks from@trigger.dev/sdk; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Add agentcrumbs while writing code using approved namespaces; mark lines with//@Crumbsor blocks with `// `#region` `@crumbs, and strip them before merging.
Files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
**/*.{test,spec}.{ts,tsx}: Use Vitest exclusively and never mock dependencies; use Testcontainers for integration dependencies.
Place test files next to the source files they test.
Files:
packages/cli-v3/src/deploy/auth.test.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
packages/cli-v3/src/deploy/**/*
📄 CodeRabbit inference engine (packages/cli-v3/CLAUDE.md)
Deploy mode code should be located in
src/deploy/and handles bundling, archiving, building Docker images, and pushing to registry
Files:
packages/cli-v3/src/deploy/auth.test.tspackages/cli-v3/src/deploy/auth.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For public packages, use
buildfor verification.
Files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tspackages/cli-v3/src/commands/preview.tspackages/plugins/src/rbac.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tsapps/webapp/app/services/authTelemetry.server.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathDo not reintroduce the removed v1 execution path;
RunEngineVersion.V1branches may only reject or finalize gracefully so v3 clients receive a clean 4xx, never a 5xx.
Files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tsapps/webapp/app/services/authTelemetry.server.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable
Files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
apps/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For apps, use
typecheckfor verification and never usebuildas the correctness check.
Files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tsapps/webapp/app/services/authTelemetry.server.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
apps/webapp/**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Test files must not import
app/env.server.ts; pass configuration as options instead.
Files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
apps/webapp/app/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/app/**/*.{ts,tsx}: For dashboard changes, visually verify the running Remix app with Chrome DevTools MCP, using snapshots, screenshots, interaction, and console-message checks as appropriate.
UseuseCallbackanduseMemoonly for context provider values, expensive derived data used as a dependency, or stable references required by dependency arrays; do not wrap ordinary event handlers or trivial computations.
Use named constants for sentinel or placeholder values instead of scattering raw string literals across comparisons.
Files:
apps/webapp/app/services/apiAuth.server.tsapps/webapp/app/services/environmentVariableApiAccess.server.tsapps/webapp/app/services/authTelemetry.server.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.ts
apps/webapp/app/**/*.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/app/**/*.ts: Never userequest.signalto detect client disconnects. UsegetRequestAbortSignal()fromapp/services/httpAsyncStorage.server.ts, which is wired to Express response close events.
Access environment variables through theenvexport fromapp/env.server.ts; never useprocess.envdirectly.
Always use PrismafindFirstinstead offindUnique.
Always use the$transactionhelper from~/db.server, never callprisma.$transactionor$replica.$transactiondirectly. Pass isolation levels as strings, useSerializablefor correctness-critical read-then-write invariants, and guard possibly undefined helper results when a definite value is required.
Files:
apps/webapp/app/services/apiAuth.server.tsapps/webapp/app/services/environmentVariableApiAccess.server.tsapps/webapp/app/services/authTelemetry.server.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.ts
packages/cli-v3/src/commands/**/*
📄 CodeRabbit inference engine (packages/cli-v3/CLAUDE.md)
CLI command definitions should be located in
src/commands/
Files:
packages/cli-v3/src/commands/preview.tspackages/cli-v3/src/commands/deploy.ts
internal-packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For internal packages, use
typecheckfor verification and never usebuildas the correctness check.
Files:
internal-packages/rbac/src/fallback.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.ts
apps/webapp/app/routes/**/*.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/app/routes/**/*.ts: Use Remix flat-file route conventions with dot-separated segments; for example,api.v1.tasks.$taskId.trigger.tsmaps to/api/v1/tasks/:taskId/trigger.
PAT-authenticated API routes must resolve their target organization or project within the caller's membership scope, using a membership filter or a helper such asfindProjectByReforresolveOrganizationForApiUser; RBAC authorization alone is insufficient.
Files:
apps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.ts
packages/cli-v3/src/commands/deploy.ts
📄 CodeRabbit inference engine (packages/cli-v3/CLAUDE.md)
Implement
deploy.tscommand insrc/commands/for production deployment
Files:
packages/cli-v3/src/commands/deploy.ts
🧠 Learnings (32)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In this repo’s trigger.dev codebase, the “never mock — use testcontainers” guideline should only be applied to integration tests that talk to real external services (e.g., Redis, Postgres, S2). For unit tests that validate in-memory logic (e.g., deduplication/cache behavior in StandardRealtimeStreamsManager and similar module-boundary call counting), it is allowed to use Vitest mocks like `vi.fn()` and to stub/mock `ApiClient` objects to count calls or simulate in-process collaborators. Do not flag `vi.fn()`-based mocks as policy violations in these unit-test scenarios; reserve the rule for true external-service integration tests.
Applied to files:
packages/cli-v3/src/deploy/auth.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
packages/cli-v3/src/deploy/auth.test.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
packages/cli-v3/src/deploy/auth.test.tspackages/plugins/src/index.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tspackages/cli-v3/src/commands/preview.tsapps/webapp/app/services/authTelemetry.server.tspackages/plugins/src/rbac.tsinternal-packages/rbac/src/fallback.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.tspackages/cli-v3/src/commands/deploy.tspackages/cli-v3/src/deploy/auth.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
packages/cli-v3/src/deploy/auth.test.tsapps/webapp/test/apiAuthScope.test.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-07-30T18:43:56.874Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4426
File: apps/webapp/test/memberDevEnvironments.server.test.ts:124-125
Timestamp: 2026-07-30T18:43:56.874Z
Learning: In the `apps/webapp` test suite (`apps/webapp/test/**`), respect the established test harness in `apps/webapp/test/setup.ts`: it loads `.env` and provides default values for required environment variables so that transitive imports (e.g., `~/env.server`) work without production-style wiring.
During code review, do not require dependency injection/refactoring solely to avoid this existing import path. Only introduce configuration injection if it delivers production-level value (for example, a more general `createEnvironment` abstraction that improves runtime behavior beyond test setup).
Applied to files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-08-08T12:49:17.489Z
Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4525
File: apps/webapp/test/dashboardAgentWatchAlertOwnerScope.test.ts:101-109
Timestamp: 2026-08-08T12:49:17.489Z
Learning: In apps/webapp/test, every test suite that creates a client with createDashboardAgentDb(connectionUri, ...) must close the DashboardAgentDbClient in afterEach. Although postgresTest drops cloned databases with WITH (FORCE), it does not clean up client-side postgres-js pool sockets or idle timers, so explicitly closing the client prevents resource leaks and test interference.
Applied to files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tsapps/webapp/app/services/authTelemetry.server.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tsapps/webapp/app/services/authTelemetry.server.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/test/apiAuthScope.test.tsapps/webapp/app/services/apiAuth.server.tsapps/webapp/test/rbacFallbackBranch.test.tsapps/webapp/app/services/environmentVariableApiAccess.server.tsapps/webapp/app/services/authTelemetry.server.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsxapps/webapp/test/environmentVariableApiAccess.test.tsapps/webapp/app/routes/api.v1.projects.$projectRef.branches.tsapps/webapp/app/routes/api.v1.projects.$projectRef.$env.tsapps/webapp/test/projectEnvironmentCredentialRoute.test.ts
📚 Learning: 2026-03-26T09:02:07.973Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3274
File: apps/webapp/app/services/runsReplicationService.server.ts:922-924
Timestamp: 2026-03-26T09:02:07.973Z
Learning: When parsing Trigger.dev task run annotations in server-side services, keep `TaskRun.annotations` strictly conforming to the `RunAnnotations` schema from `trigger.dev/core/v3`. If the code already uses `RunAnnotations.safeParse` (e.g., in a `#parseAnnotations` helper), treat that as intentional/necessary for atomic, schema-accurate annotation handling. Do not recommend relaxing the annotation payload schema or using a permissive “passthrough” parse path, since the annotations are expected to be written atomically in one operation and should not contain partial/legacy payloads that would require a looser parser.
Applied to files:
apps/webapp/app/services/apiAuth.server.tsapps/webapp/app/services/environmentVariableApiAccess.server.tsapps/webapp/app/services/authTelemetry.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/services/apiAuth.server.tsapps/webapp/app/services/environmentVariableApiAccess.server.tsapps/webapp/app/services/authTelemetry.server.ts
📚 Learning: 2026-05-01T15:45:05.096Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3499
File: internal-packages/rbac/src/fallback.ts:34-107
Timestamp: 2026-05-01T15:45:05.096Z
Learning: When reviewing triggerdotdev/trigger.dev RBAC auth code, do not treat missing Personal Access Token (PAT) handling inside `authenticateBearer` as a bug. `authenticateBearer` is intentionally scoped to runtime environment API keys and Public JWTs only; PAT auth is handled via the separate PAT route builder (e.g., `createLoaderPATApiRoute`) which calls `authenticateApiRequestWithPersonalAccessToken` directly. Ensure that reviewers compare auth behavior against these distinct architectural paths (OSS fallback and cloud plugin) before flagging an issue.
Applied to files:
internal-packages/rbac/src/fallback.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.ts
📚 Learning: 2026-05-09T08:07:24.612Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3499
File: internal-packages/rbac/src/fallback.ts:271-277
Timestamp: 2026-05-09T08:07:24.612Z
Learning: When reviewing RBAC/auth code that looks up or validates `PersonalAccessToken` (PAT), do not flag missing `expiresAt`/expiration checks: the PAT model has no `expiresAt` column and is treated as perpetual until manually revoked via `revokedAt`. Only require/enforce expiration logic when the code is dealing with `OrganizationAccessToken`, which does have an `expiresAt` field (and should be checked accordingly).
Applied to files:
internal-packages/rbac/src/fallback.tsinternal-packages/rbac/src/index.tsinternal-packages/rbac/src/bearerCredentials.ts
📚 Learning: 2026-02-03T18:27:40.429Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 2994
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables/route.tsx:553-555
Timestamp: 2026-02-03T18:27:40.429Z
Learning: In apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables/route.tsx, the menu buttons (e.g., Edit with PencilSquareIcon) in the TableCellMenu are intentionally icon-only with no text labels as a compact UI pattern. This is a deliberate design choice for this route; preserve the icon-only behavior for consistency in this file.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsx
📚 Learning: 2026-07-22T11:16:06.546Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 4332
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.regions/route.tsx:166-168
Timestamp: 2026-07-22T11:16:06.546Z
Learning: In the Trigger.dev web app, copy-interaction accessibility (keyboard and touch behavior for the copy affordance) is owned by the shared `CopyableText` `icon-right` primitive. When reviewing route-level code (e.g., admin debug panels and runs tables) that intentionally reuses this pattern, avoid suggesting divergent call-site-only accessibility fixes; instead, route any accessibility changes back to a holistic update of the `CopyableText` `icon-right` implementation so all reuse sites benefit consistently.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsx
📚 Learning: 2026-02-11T16:37:32.429Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3019
File: apps/webapp/app/components/primitives/charts/Card.tsx:26-30
Timestamp: 2026-02-11T16:37:32.429Z
Learning: In projects using react-grid-layout, avoid relying on drag-handle class to imply draggability. Ensure drag-handle elements only affect dragging when the parent grid item is configured draggable in the layout; conditionally apply cursor styles based on the draggable prop. This improves correctness and accessibility.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsx
📚 Learning: 2026-07-28T21:57:20.061Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 4411
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.team/route.tsx:818-843
Timestamp: 2026-07-28T21:57:20.061Z
Learning: When using Radix UI `DialogClose` with `asChild` (e.g., Trigger.dev dashboard components), note that it injects `type="button"` into its child via `Slot`. If the child is a local `Button` that forwards its `type` prop to the native `<button>`, then placing it inside a `<form>` will *not* submit unless you explicitly set `type="submit"` (or otherwise override the injected type / wire up submission behavior). Review form actions to ensure the intended submit vs non-submit behavior is preserved.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsx
📚 Learning: 2026-04-02T19:18:26.255Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3319
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions/route.tsx:179-189
Timestamp: 2026-04-02T19:18:26.255Z
Learning: In this repo’s route components that render the Inspector `ResizablePanelGroup` panels, it’s acceptable to pass `collapsed={!isShowingInspector}` together with a no-op `onCollapseChange={() => {}}` when panel visibility is intentionally controlled only by route parameters (e.g., `*Param` search/route params) rather than user drag/collapse interactions. Do not flag an empty/no-op `onCollapseChange` as “missing wiring” in these cases; only flag it when collapse state is expected to change based on user interaction.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsx
📚 Learning: 2026-05-12T21:04:00.184Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.sessions._index/route.tsx:40-42
Timestamp: 2026-05-12T21:04:00.184Z
Learning: In triggerdotdev/trigger.dev route loader implementations (Remix `route.tsx` files under `apps/webapp/app/routes/**`), follow the existing convention for missing/unauthorized environment lookups: when `findEnvironmentBySlug` (or the equivalent env resolver) returns a falsy value, handle it by throwing `new Error("Environment not found")` rather than returning a `404` `Response` (i.e., do not flag this as “missing 404 response”). Changing the error-to-404 convention is a cross-cutting refactor and should be left out of individual PRs unless the PR explicitly addresses that broader migration.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsx
📚 Learning: 2026-05-08T21:00:20.973Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3538
File: apps/webapp/app/components/primitives/Resizable.tsx:60-78
Timestamp: 2026-05-08T21:00:20.973Z
Learning: In the triggerdotdev/trigger.dev codebase, treat Zod as a boundary validation tool (API handlers, request/response validation, and storage/DB read/write validation), not as inline render-time validation inside React components/primitive UI code. For render-time guards, prefer small manual type-narrowing checks (e.g., a short predicate like ~10–20 lines) over importing Zod into UI primitives, to avoid per-render schema-parse overhead and unnecessary abstraction. Use the manual guard approach unless you truly need schema validation at a boundary; only then introduce Zod.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsx
📚 Learning: 2026-06-25T18:21:55.847Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-resend.tsx:0-0
Timestamp: 2026-06-25T18:21:55.847Z
Learning: In the triggerdotdev/trigger.dev Zod 4 migration, avoid importing from the root package `conform-to/zod` in webapp code. It can resolve to the Zod 3 build and may crash at module load under Zod 4. When reviewing TypeScript/TSX files in `apps/webapp`, prefer importing from the Zod 4 subpath `conform-to/zod/v4` for Zod 4-compatible schemas/types.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsx
📚 Learning: 2026-06-25T18:21:54.729Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/confirm-basic-details.tsx:0-0
Timestamp: 2026-06-25T18:21:54.729Z
Learning: For Remix + TypeScript files that use Conform v1 (conform-to/react) and its getInputProps helper, when you intend to suppress the helper-provided default value for non-checkbox/non-radio inputs (e.g., hidden inputs managed via an explicit value prop), use the Conform v1 option key `value: false`. Do not recommend `defaultValue: false` here, because `defaultValue` is not a valid option key for these input types in Conform v1 typings.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsx
🔇 Additional comments (21)
packages/plugins/src/rbac.ts (1)
199-199: LGTM!Also applies to: 360-365, 416-416, 464-464
packages/plugins/src/index.ts (1)
28-28: LGTM!internal-packages/rbac/src/index.ts (1)
4-4: LGTM!Also applies to: 23-28, 48-48
internal-packages/rbac/src/fallback.ts (1)
7-7: LGTM!Also applies to: 88-88, 175-175
internal-packages/rbac/src/bearerCredentials.ts (1)
8-8: LGTM!Also applies to: 84-84, 225-234, 275-275, 301-302, 327-331, 397-400
apps/webapp/app/services/authTelemetry.server.ts (1)
4-4: LGTM!Also applies to: 43-46, 83-83
apps/webapp/app/services/apiAuth.server.ts (1)
16-16: LGTM!Also applies to: 35-35, 288-318, 334-355
apps/webapp/app/services/environmentVariableApiAccess.server.ts (1)
6-6: LGTM!Also applies to: 32-38, 48-52, 82-115
apps/webapp/test/apiAuthScope.test.ts (1)
1-9: LGTM!Also applies to: 66-66, 80-109
apps/webapp/test/environmentVariableApiAccess.test.ts (1)
3-10: LGTM!Also applies to: 37-91
apps/webapp/app/routes/api.v1.projects.$projectRef.branches.ts (2)
6-158: LGTM!
164-164: 🗄️ Data Integrity & IntegrationNo change needed.
The API upsert branch response contract matches
UpsertBranchResponseBody, and the CLI upsert path uses that response shape.apps/webapp/app/routes/api.v1.projects.$projectRef.$env.ts (1)
11-12: LGTM!Also applies to: 33-35, 49-64
apps/webapp/test/projectEnvironmentCredentialRoute.test.ts (1)
4-15: LGTM!Also applies to: 57-57, 66-66, 86-90, 113-113, 127-127
apps/webapp/test/rbacFallbackBranch.test.ts (1)
198-239: LGTM!Also applies to: 597-630
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.apikeys/route.tsx (1)
875-875: LGTM!Also applies to: 885-885, 922-922
packages/cli-v3/src/deploy/auth.ts (1)
1-78: LGTM!packages/cli-v3/src/commands/deploy.ts (1)
14-14: LGTM!Also applies to: 33-33, 272-277, 373-373, 429-429
packages/cli-v3/src/commands/preview.ts (1)
131-131: LGTM!packages/cli-v3/src/deploy/auth.test.ts (1)
1-98: LGTM!.changeset/deploy-api-keys.md (1)
1-5: LGTM!
Contributor
Observability mapAs of 18/100 over 414 measured of 430 entry points (base 18, no change) What this PR changed
FIX FIRST
AUDIT 3 of 50 sensitive mutations record an actor. 47 without one. What the score is made ofThe score and findings here are report-only and never gate the merge. Separately, a required test suite keeps this tool's symbol and route lists in sync with the code they name, and can fail a pull request that renames or removes a symbol they reference, or that adds the first route with a segment they anticipate. Each failure names the list to edit. The rules and their reasons: internal-packages/observability-map/README.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trigger deploycan authenticate directly withTRIGGER_SECRET_KEY, including restricted environment API keys. API key credentials take precedence over user authentication and work for standard, native, and Preview deployments without login or user metadata.Design
Project environment bootstrap now echoes the exact environment key presented by the caller instead of exchanging an additional key for the root key. User token behavior and permission checks remain unchanged.
Preview branch creation accepts environment API keys with
write:branches, restricted to the key's own project and parent Preview environment. Deploy links remain available without user metadata, while deployment attribution stays optional.