Skip to content

fix(sdk): guard against null output in wait token timeout error #4542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
okxint wants to merge 2 commits into from
+7 −2
Closed

fix(sdk): guard against null output in wait token timeout error #4542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c553769
fix(sdk): guard against null output in wait token timeout error
okxint Aug 9, 2026
b265664
chore: add changeset for wait token null output fix
okxint Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-wait-token-null-output-crash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@trigger.dev/sdk": patch
---

Fix crash when a timed-out waitpoint token has no output payload. When `result.output` is null, `data` is `undefined` and accessing `data.message` throws a `TypeError` before the timeout error reaches the caller. Uses optional chaining with a fallback message, matching the pattern already used in `sharedRuntimeManager` for the same case.
4 changes: 2 additions & 2 deletions packages/trigger-sdk/src/v3/wait.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ async function retrieveToken<T>(
let output: T | undefined = undefined;

if (result.outputIsError) {
error = new WaitpointTimeoutError(data.message);
error = new WaitpointTimeoutError(data?.message ?? "Waitpoint timed out");
} else {
output = data as T;
}
Expand Down Expand Up @@ -615,7 +615,7 @@ export const wait = {
output: data,
} as WaitpointTokenTypedResult<T>;
} else {
const error = new WaitpointTimeoutError(data.message);
const error = new WaitpointTimeoutError(data?.message ?? "Waitpoint timed out");

span.recordException(error);
span.setStatus({
Expand Down