fix: sync declarative schedules on deployment rollback#3468
fix: sync declarative schedules on deployment rollback#3468devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
When rolling back a deployment via ChangeCurrentDeploymentService, declarative schedules were not being synced to match the rolled-back deployment's worker metadata. This caused schedules to remain as configured by the most recent deployment instead of reflecting the target deployment's schedule configuration. The fix adds a call to syncDeclarativeSchedules after the deployment promotion is updated, using the target deployment's worker metadata to restore the correct schedule state. Co-Authored-By: nick <55853254+nicktrn@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: nick <55853254+nicktrn@users.noreply.github.com>
End-to-End Test ResultsRan the webapp locally with seeded test data (two deployments with different schedule crons). All tests passed. Test Results (3/3 passed)
Before/After EvidenceInitial State (v2 = Current, cron =
|
| Deployments | Schedules |
|---|---|
After Rollback to v1 (v1 = Current, cron = 0 9 * * *)
| Deployments | Schedules |
|---|---|
After Promote back to v2 (v2 = Current, cron = 0 17 * * *)
| Deployments | Schedules |
|---|---|
DB Verification
-- Before rollback:
test_schedule|my-scheduled-task|0 17 * * *|UTC|test_schedule_instance|t
-- After rollback to v1:
test_schedule|my-scheduled-task|0 9 * * *|UTC|test_schedule_instance|t
-- After promote back to v2:
test_schedule|my-scheduled-task|0 17 * * *|UTC|test_schedule_instance|t
|
ready |
1 participant
✅ Checklist
Testing
ChangeCurrentDeploymentService) and confirmed it was missing schedule syncChangeCurrentDeploymentService(UI rollback, UI promote, API promote, finalize deployment) are now coveredpnpm run typecheck --filter webapp— passes cleanlyChangelog
When rolling back (or manually promoting) a deployment, declarative schedules were not being synced to match the target deployment's worker metadata. Schedules remained as configured by the most recent deployment rather than reflecting the target version's schedule configuration.
This fix adds a call to
syncDeclarativeSchedulesinChangeCurrentDeploymentServiceafter the deployment promotion is updated. It parses the target deployment's storedBackgroundWorkerMetadatato restore the correct schedule state. This covers both rollback and promote paths (UI and API). Errors are handled gracefully so they don't block the deployment change itself.Screenshots
N/A — backend-only change.
💯
Link to Devin session: https://app.devin.ai/sessions/0debf012b58c4132be778f8ea88cd2b6