fix(sdk): return annotation create response - #4451
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughAnnotation creation now returns the HTTP write result. User feedback tests verify successful responses and a ChangesAnnotation feedback
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change returns annotation API responses to callers and documents success and failure behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The change addresses issue ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
HTTPClient.post()result fromBaseAnnotation.create()/UserFeedback.create()Nonewhen the HTTP client cannot complete the writeFixes #4402.
Also addresses duplicate #4404.
Tests
env PYTHONPATH=../opentelemetry-semantic-conventions-ai .venv-codex/bin/python -m pytest tests/test_user_feedback.py -q.venv-codex/bin/ruff check traceloop/sdk/annotation/base_annotation.py traceloop/sdk/annotation/user_feedback.py tests/test_user_feedback.pygit diff --checkChecklist
feat(instrumentation): ...orfix(instrumentation): ....Summary by CodeRabbit
New Features
Bug Fixes
Tests