Consolidate bot PRs #379-#383 and fix pytest incompatibility blocking their CI#384
Conversation
updates: - [github.com/python-jsonschema/check-jsonschema.git: 0.37.2 -> 0.37.4](https://github.com/python-jsonschema/check-jsonschema.git/compare/0.37.2...0.37.4) - [github.com/codespell-project/codespell: v2.4.2 -> v2.4.3](codespell-project/codespell@v2.4.2...v2.4.3) - [github.com/astral-sh/ruff-pre-commit: v0.15.13 -> v0.15.22](astral-sh/ruff-pre-commit@v0.15.13...v0.15.22)
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 657 657
Branches 85 85
=========================================
Hits 657 657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 351ccbfc23
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - repo: https://github.com/python-jsonschema/check-jsonschema.git | ||
| rev: 0.37.2 | ||
| rev: 0.37.4 |
There was a problem hiding this comment.
Add the missing changelog entry
This PR changes CI/dependency configuration and a test, but docs/reference/changelog.md was not updated; its Unreleased CI/CD section still stops at earlier PRs, so the check-release-notes workflow will keep MISSING_CHANGELOG_ENTRY=1 and fail for any normal PR unless someone applies skip news. Please add the {gh-pr} changelog entry for this change so CI can pass.
Useful? React with 👍 / 👎.
Re-applies the changes from 5 open bot PRs into a single branch (following the precedent set by #378), together with the test-suite fix that was causing their CI failures.
Why were these PRs failing CI?
All five bot PRs were failing the Software tests jobs for a reason unrelated to their changes: the latest pytest release deprecated passing a lazy iterator to
pytest.mark.parametrize, andtests/unit/test_utils.py::TestGetXYExtremapassed anitertools.productobject directly. Since the test config turns warnings into errors, collection failed everywhere (and the same deprecation also trips pyright in Static checks, seen on #383). The first commit here wraps it inlist(...).Consolidated changes
379): check-jsonschema 0.37.2 → 0.37.4, codespell v2.4.2 → v2.4.3, ruff v0.15.13 → v0.15.22ci.ymlstill supportedpull_request_target/workflow_runworkflows that check out code — none here doChangelog updated under
Unreleased changes > CI/CD.Closes #379
Closes #380
Closes #381
Closes #382
Closes #383
📚 Documentation preview 📚: https://ridgeplot--384.org.readthedocs.build/en/384/