Use () around <Plug> mappings#179
Open
djpohly wants to merge 1 commit into
Open
Conversation
<Plug> is merely a special keycode, so "<Plug>Commentary" is a prefix of e.g. "<Plug>CommentaryLine", which means you have to wait for 'timeoutlen' before the former mapping takes place to make sure you're not actually going to enter the latter. (Type "gcLine" from Normal mode, watch the 'showcmd' output and see what gets called!) It's common practice to use parentheses to prevent one mapping from prefixing another, so that's the fix suggested here. (Another option would be a terminator, as suggested in ":help using-<Plug>".) May be related to the issue seen in tpope#105, given that it was affected by changes to 'timeoutlen'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Plug>is merely a special keycode, so<Plug>Commentaryis a prefix of e.g.<Plug>CommentaryLine, which means you have to wait for 'timeoutlen' before the former mapping takes place to make sure you're not actually going to enter the latter. (Type "gcLine" from Normal mode, watch the 'showcmd' output and see what gets called!)It's common practice to use parentheses to prevent one mapping from prefixing another, so that's the fix suggested here. (Another option would be a terminator, as suggested in
:help using-<Plug>.)May be related to the issue seen in #105, given that it was affected by changes to 'timeoutlen'.
(Upgrade notes: users will need to make a small update to their configuration if they have anything mapped to
<Plug>sequences. Alternatively, the old mappings could be left in place alongside the new ones, with the note that this issue will remain until you update.)