fix(queryset): preserve select_for_update in values and values_list#2253
Open
arimu1 wants to merge 1 commit into
Open
fix(queryset): preserve select_for_update in values and values_list#2253arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2250
When
values()orvalues_list()was chained afterselect_for_update(), the select_for_update parameters were not passed toValuesQuery/ValuesListQuery, causing the SQL generator to dropFOR UPDATEclauses and lose row locking behavior.This change passes and preserves
select_for_updateparameters inValuesQueryandValuesListQuery.