feat: improve type inference for related fields#2179
Open
legau wants to merge 2 commits intotortoise:developfrom
Open
feat: improve type inference for related fields#2179legau wants to merge 2 commits intotortoise:developfrom
legau wants to merge 2 commits intotortoise:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves typing for relational field factories so passing a model class preserves the concrete related model type in the returned relation.
Motivation and Context
Currently, relational field factories expose a free type variable but accepted
type[Model] | str, which prevents type checkers from inferring the concrete related model when a real model class was passed.This meant code like
fields.ForeignKeyField(Field, related_name="segments")would not resolve toForeignKeyRelation[Field].How Has This Been Tested?
Added a type checking test file
Checklist: