Skip to content

docs: add root CLAUDE.md naming make test as the verification command - #83

Merged
topij merged 1 commit into
mainfrom
dev/root-claude-md
Jul 27, 2026
Merged

docs: add root CLAUDE.md naming make test as the verification command#83
topij merged 1 commit into
mainfrom
dev/root-claude-md

Conversation

@topij

@topij topij commented Jul 27, 2026

Copy link
Copy Markdown
Owner

What

Adds a root CLAUDE.md with two sections:

  • Verification — names make test as the verification command and documents the two probes that fail in a way that reads as "pytest is unavailable" (uv run pytest, python3 -m pytest).
  • Ground rules — standing repo rules that have repeatedly cost review rounds when rediscovered from scratch: protected main + pr-watch, config in config/dev-model.yaml, the living handoff / friction log, and the conservative closing-keyword rule (as settled in 42873d8).

Why

The friction log (2026-07-27, H) records that no markdown file in the repo mentions make test and there is no root CLAUDE.md. The previous session concluded tests could not run locally and wrote a false "tests were not run locally — pytest is not installed" into the body of a merged PR (#80). This file is the discoverability precondition for #54 (#54 stays open — it proposes the rule itself; this change only makes the rule satisfiable).

Verification

Run in this session, before writing the file:

  • make test372 passed in 22.95s
  • uv run pytesterror: Failed to spawn: pytest — No such file or directory
  • python3 -m pytest --versionNo module named pytest

The file's claims about the suite paths match Makefile:31-32. Docs-only change; no engine or config touched.

Summary by CodeRabbit

  • Documentation
    • Added repository guidance covering test verification, configuration management, protected branch practices, documentation references, and issue-closing wording.
    • Documented how to interpret local test-environment limitations.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 41200de4-2cca-4280-8507-ca16d8f992fa

📥 Commits

Reviewing files that changed from the base of the PR and between 916adef and 0874992.

📒 Files selected for processing (1)
  • CLAUDE.md

📝 Walkthrough

Walkthrough

Added CLAUDE.md with repository verification instructions and operational ground rules covering testing, branching, configuration, documentation, and issue wording.

Changes

Repository operating rules

Layer / File(s) Summary
Verification and ground rules
CLAUDE.md
Documents make test, pytest availability guidance, protected branch behavior, centralized configuration, living documentation references, and issue wording constraints.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main documentation change: adding a root CLAUDE.md and defining make test as the verification command.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/root-claude-md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@topij

topij commented Jul 27, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant