Conversation
What was broken The previous PM-5562 follow-up made Development totals include aggregate wins for subtracks whose history had no placement data. QA still found that the profile totals for pops and wleite showed 76 instead of 152 and 2 instead of 36. Root cause Legacy Marathon Match history is partial but contains placement fields. The shared subtrack summary therefore treated those incomplete rows as the source of truth and replaced 76 and 34 valid aggregate wins with zero placement wins. The prior fix only covered histories with no placement fields at all. What was changed Keep an explicit aggregate wins value authoritative for Marathon Match while retaining placement-derived wins for modern tracks. This preserves the earlier Development deduplication and rating-only history fixes. Any added/updated tests Added a regression case modeled on the pops payload, proving that 76 aggregate Marathon Match wins survive a partial placement history with no first-place rows. The existing placement-history and Development aggregation tests remain passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The previous PM-5562 follow-up fixed Development totals for subtracks whose
history had no placement data. QA still found that profile totals for
popsand
wleiteshowed 76 instead of 152 and 2 instead of 36.Root cause
Both remaining gaps are legacy Marathon Match wins. Those history payloads
contain placement fields but are incomplete:
popshas 5 history rows for 225challenges and
wleitehas 87 rows for 575 challenges. None of those partialrows records a first place, so the shared subtrack summary replaced valid
aggregate win counters (76 and 34) with zero placement wins. The prior fix only
covered histories with no placement fields at all.
What was changed
MARATHON_MATCH.PM-5458 stale-counter correction.
Any added/updated tests
getSubTrackSummaryStatsregression case modeled on thepopspayload, proving that 76 aggregate Marathon Match wins survive partial
placement history with no first-place rows.
yarn test:no-watch src/apps/profiles/src/hooks/useFetchActiveTracks.spec.tsxpasses: 15 tests.
yarn lintpasses cleanly.yarn run buildsucceeds; it reports only existing repository warnings.popsand 36 forwleite,matching their API totals.
The broader profiles test command was also run: 14 suites pass, including all
PM-5562 coverage. Two unrelated baseline suites still fail for the same reasons
recorded on the prior attempt:
MemberRatingCardis missing auseProfileCompletenessmock, andMemberRatingInfoModalhas a stale2200+expectation.