fix: parse aa dump missions separately and prefer FOREGROUND - #2
Draft
tonycoder-hub wants to merge 1 commit into
Draft
fix: parse aa dump missions separately and prefer FOREGROUND#2tonycoder-hub wants to merge 1 commit into
tonycoder-hub wants to merge 1 commit into
Conversation
current_app() included the dump's closing '}' in the mission regex, so findall swallowed the whole list as one match and returned the first bundle name (often BACKGROUND). Drop the trailing '}' so each mission is one match, and return the FOREGROUND app when several exist. Fixes codematrixer#52 Fixes codematrixer#42 Co-authored-by: Tony Jin <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended as an upstream PR against codematrixer/hmdriver2
master(fixes codematrixer#52 and codematrixer#42 there). The cloud token cannot open that PR; from a fork with write access run:Problem
current_app()parsedhdc shell aa dump -lwith:The trailing
}belongs tocurrent mission lists:{ ... }, not to a single mission.findalltherefore returned one match covering the whole dump. The firstbundle name/main namein that match was used — typically a BACKGROUND app — even when a later mission was FOREGROUND.Changes
}so each mission is one regex match._parse_current_app()and prefer missions withstate #FOREGROUND/app state #FOREGROUND.current_app()returns yang, not photos.No device is required to run: