Allow lxml 6.x by raising the upper bound - #1
Draft
tonycoder-hub wants to merge 1 commit into
Draft
Conversation
Poetry caret ^5.3.0 excluded lxml 6.0+, which blocked installs that already require 6.0.2. Keep 5.3.0 as the floor and allow the 6.x series (<7). Co-authored-by: Tony Jin <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes codematrixer#51.
lxml = "^5.3.0"is Poetry for>=5.3.0,<6.0.0, which rejects lxml 6.0.2. Environments that already require lxml 6.x cannot install hmdriver2.This only changes the constraint to
>=5.3.0,<7.0.0so 5.3+ and the 6.x series are both allowed. No lockfile or requirements file is present.Verified on the host (no Harmony device):
pip install lxml==6.0.2plus editablehmdriver2resolves aslxml (>=5.3.0,<7.0.0)→ 6.0.2import hmdriver2,hmdriver2.driver,hmdriver2._xpath,hmdriver2._client_XPath._json2xml+ xpath queries (//*[@text="showDialog"],//root[1]/Row[1]/Button[1]) and control-character sanitizationExisting
tests/need a connected Harmony device and were not run.