Pin CS2 2000872 hl2sdk for native rebuild#1
Conversation
📝 WalkthroughWalkthroughUpdated the hl2sdk-cs2 submodule configuration in .gitmodules to point to a new repository URL and branch, and bumped the pinned submodule commit hash to reflect the new source. ChangesSubmodule source and commit update
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78bdd12294
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| url = https://github.com/tomastaker/hl2sdk | ||
| branch = codex/cs2-2000872-metamod-css-fix |
There was a problem hiding this comment.
In the roflmuffin/CounterStrikeSharp repo, Dependabot is already configured to update libraries/hl2sdk-cs2 daily and the workflow auto-approves/merges any Dependabot PR whose dependency list contains that submodule (.github/dependabot.yaml:3-11, .github/workflows/pr-auto-approve-dependabot.yaml:20-24). With this URL/branch now pointing at a personal fork, any future update published there can be proposed by Dependabot and merged automatically into the native build; if this is meant to pin one temporary SDK commit, avoid tracking the fork for automated updates or disable the hl2sdk auto-merge until it is back on a trusted upstream.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
libraries/hl2sdk-cs2 (1)
1-1: 🔒 Security & Privacy | 🔵 Trivial | ⚖️ Poor tradeoffAvoid pinning
libraries/hl2sdk-cs2to a personal fork. It’s tied totomastaker/hl2sdkoncodex/cs2-2000872-metamod-css-fix; if that fork or branch goes away,git submodule update --initbreaks. Move it to an org-owned mirror or upstream the patch when possible.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@libraries/hl2sdk-cs2` at line 1, The hl2sdk-cs2 submodule is pinned to a personal fork/branch, so update the submodule reference to an org-owned mirror or upstream source instead of tomastaker/hl2sdk. Adjust the submodule configuration and any commit reference used by git submodule update --init so the dependency is no longer tied to that personal branch and remains fetchable long term.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@libraries/hl2sdk-cs2`:
- Line 1: The hl2sdk-cs2 submodule is pinned to a personal fork/branch, so
update the submodule reference to an org-owned mirror or upstream source instead
of tomastaker/hl2sdk. Adjust the submodule configuration and any commit
reference used by git submodule update --init so the dependency is no longer
tied to that personal branch and remains fetchable long term.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 925b8f1e-c237-44c1-9ff6-0c34ee31b9c3
📒 Files selected for processing (2)
.gitmoduleslibraries/hl2sdk-cs2
1 participant
Что меняется
Зачем
После CS2 2000872 официальный CounterStrikeSharp v1.0.370 native binary импортировал устаревшие symbols g_bUpdateStringTokenDatabase / RegisterStringToken и не мог загрузиться вместе с исправленным Metamod. Rebuild against patched hl2sdk убирает эти imports.
Проверка
Оставшийся риск
CounterStrikeSharp всё ещё пишет missing signatures для Host_Say, CEntityInstance_AcceptInput, CBaseEntity_TakeDamageOld. Текущий CommendBoostPlugin эти API не использует; для полного upstream CSS health нужно отдельно обновить gamedata signatures.
Summary by CodeRabbit