feat(clickhouse): parse trimLeft/trimRight/trimBoth into Trim - #8240
Merged
Conversation
ClickHouse's trimLeft, trimRight and trimBoth take an optional second argument naming the characters to strip, but the parser left all three as Anonymous, so they reached every target dialect verbatim as TRIMLEFT(s, 'x'). Register them on exp.Trim with the LEADING/TRAILING/ BOTH position so they transpile (DuckDB LTRIM(s, 'x'), Postgres TRIM(LEADING 'x' FROM s), ...) and round-trip to the TRIM(... FROM ...) form the ClickHouse generator already emits.
geooo109
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickHouse's
trimLeft,trimRightandtrimBothtake an optional second argument naming the characters to strip, but the parser left all three as Anonymous, so they reached every target dialect verbatim (TRIMLEFT(s, 'x')).This registers them on
exp.Trimwith the LEADING/TRAILING/BOTH position (reusingparser.build_trimfor the left/right cases), so they transpile — DuckDBLTRIM(s, 'x'), Doris/PostgresTRIM(LEADING 'x' FROM s)— and round-trip to theTRIM(... FROM ...)form the ClickHouse generator already emits (and which the existing identity tests at the same spot assert as canonical).Before:
After: