refactor(datatypes): improve typing#7654
Open
OutSquareCapital wants to merge 5 commits into
Open
Conversation
|
|
||
|
|
||
| class DataTypeArgs(ParserNoDialectArgs, total=False): | ||
| expressions: list[exp.Literal | exp.Neg | exp.DataTypeParam | exp.ColumnDef] |
Contributor
Author
There was a problem hiding this comment.
Unfortunately this couldn't be narrowed in the other way, i.e DataType::expressions, since there's a lot of unsafe attributes acces that would require logic change instead of pure typing changes.
I determined the values simply by dummy typing it as list[float] at first, and then adjusting depending on the errors:
sqlglot\generator.py:5042: error: List item 0 has incompatible type "Literal | Neg"; expected "float" [list-item]
sqlglot\dialects\dialect.py:1731: error: List item 0 has incompatible type "DataTypeParam"; expected "float" [list-item]
sqlglot\optimizer\simplify.py:20: error: Library stubs not installed for "dateutil.relativedelta" [import-untyped]I also knew that struct types use exp::ColumnDef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improve the
expressions::datatypes::{DataType, DataTypeParam}type safety, with thekwargsargument inDataType::buildnarrowed from object to a new dedicatedTypedDictin the_typingmodule, and a narrowedthisproperty onDataTypeParam