fix(skills): align tool names with exported MCP schema - #779
Conversation
|
Thanks, the underlying problem is real and verified: the server exports *_tool names (main.py) while the skill templates referenced bare names, and your renames all match the exported schema. Two gaps before this can merge: (1) skills/debug-issue/SKILL.md (lines 14 and 25) and skills/review-changes/SKILL.md (line 27) still contain the old bare names (get_flow, get_minimal_context). You fixed the skills.py templates for those two skills but not the bundled files, so the generated and bundled copies now disagree, and the bundled files are what the sdist and the Qoder installer ship. (2) The new test only checks explore-codebase and refactor-safely, which is why it passes despite the leftover stale names; please extend expected_tools/legacy checks to all four skills so the guard actually covers the claim in the PR description. Optional follow-up (fine as a separate PR): prompts.py MCP prompt templates and hints.py next_tool_suggestions have the same bare-name drift. Full suite passes locally on your branch (2306 passed) and ruff is clean. |
|
Thank you for the review. I missed that. I have pushed the suggested changes:
I also noticed that skills.py currently defines only four skills, while there are additional .md files. I will check whether this is expected; if not, I will open a separate pull request. |
Summary:
Validation:
Notes: