Skip to content

feat(platform): add MiMo Code MCP support - #688

Open
Aditya-Tripuraneni wants to merge 2 commits into
tirth8205:mainfrom
Aditya-Tripuraneni:feat/mimo-platform-support
Open

feat(platform): add MiMo Code MCP support#688
Aditya-Tripuraneni wants to merge 2 commits into
tirth8205:mainfrom
Aditya-Tripuraneni:feat/mimo-platform-support

Conversation

@Aditya-Tripuraneni

Copy link
Copy Markdown

Pull Request

Linked issue

closes #593

What & why

This pull request adds support for MiMo Code as an MCP install target, allowing users to configure code-review-graph for MiMo Code projects. The implementation ensures that MiMo Code's configuration is project-local, preserves existing settings, and integrates smoothly with the install and uninstall workflows. Documentation and tests have also been updated to reflect and verify this new platform support.

How it was tested

uv run pytest tests/ --tb=short -q
uv run ruff check code_review_graph/
uv run mypy code_review_graph/ --ignore-missing-imports --no-strict-optional

MiMo Code Platform Support

  • Added MiMo Code as an installable platform via the CLI (--platform mimo), updating _PLATFORM_CHOICES and all related documentation to list MiMo Code as a supported platform. [1] [2] [3] [4] [5]
  • Implemented MiMo Code platform configuration in skills.py, including detection logic, config file path, and schema for the local MCP server command. The configuration is written to .mimocode/mimocode.json and preserves any existing configuration. [1] [2]
  • Updated documentation (CHANGELOG.md, README.md, docs/USAGE.md, docs/architecture.md) to describe MiMo Code support, configuration file location, and installer behavior. [1] [2] [3]

Testing

  • Added unit tests to verify that MiMo Code is registered correctly, writes a runnable project config, preserves existing servers, and that the install is idempotent and respects dry-run mode. [1] [2] [3]

@tirth8205

Copy link
Copy Markdown
Owner

The MiMo config shape matches the published contract and the four focused synthetic tests pass. I am keeping this open because the linked issue states MiMo was not installed, so discovery, MCP invocation, idempotent reinstall, and surgical uninstall have not been exercised in a released MiMo client. Please provide those four real-client results before merge.

@tirth8205

Copy link
Copy Markdown
Owner

Code-side validation is green: 240 tests pass. A real CLI install → reinstall → uninstall cycle was also checked; reinstall is byte-idempotent, and uninstall removes only the CRG entry while preserving $schema, theme, and unrelated MCP entries. The current official MiMo configuration path and shape also match this implementation.

The remaining blocker is released MiMo-client proof. MiMo is not installed in this environment, and I will not claim discovery or a handshake without running it. Please rebase and provide mimo --version, mimo mcp list, one successful CRG server/tool invocation, reinstall, and uninstall results from an isolated project. After that, this is mergeable.

@tirth8205 tirth8205 mentioned this pull request Jul 27, 2026
1 task
@tirth8205

Copy link
Copy Markdown
Owner

One additional rebase requirement: current MiMo Code supports both .mimocode/mimocode.json and .mimocode/mimocode.jsonc, loading JSONC after JSON. This branch only writes and tests .json. Please add a regression using an existing .jsonc file and confirm that CRG is discovered, invoked, reinstalled, and removed without changing unrelated JSONC settings.

The branch is also 96 commits behind and currently conflicts with main. Rebase and run the complete CI matrix after real-client validation.

@tirth8205

Copy link
Copy Markdown
Owner

The implementation matches MiMo's published config contract (.mimocode/mimocode.json, top-level mcp key, type local with a command array) and the branch passes the full suite locally (1966 passed) plus ruff. The blockers from earlier review still stand: the branch is over 100 commits behind main and conflicts in CHANGELOG.md and tests/test_cli_install.py; .mimocode/mimocode.jsonc is not handled (compare _opencode_config_path, which prefers .jsonc when present) and has no regression test; and the real-client evidence requested on July 27 (mimo --version, mimo mcp list, one CRG tool invocation, reinstall, uninstall from an isolated project) has not been provided. Please rebase, add the .jsonc handling and test, and post the client results so the full CI matrix can run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Platform]:

2 participants