TINY-12656: Add new custom rule to enforce type location - #55
Open
ltrouton wants to merge 7 commits into
Open
Conversation
ltrouton
requested review from
a team,
jscasca,
kimwoodfield,
metricjs and
shanmen-tiny
and removed request for
a team
December 17, 2025 00:30
ltrouton
requested review from
TheSpyder,
kemister85,
spocke and
tiny-stale-bot
December 17, 2025 00:30
5 tasks
MitchC1999
approved these changes
Dec 17, 2025
TheSpyder
reviewed
Dec 17, 2025
| */ | ||
| const isTypeDeclaration = (node: TSESTree.Node): boolean => { | ||
| if (TYPE_DECLARATION_NODE_TYPES.includes(node.type)) { | ||
| return true; |
Member
There was a problem hiding this comment.
As the AI points out on your tinymce PR, TypeScript is not this simple. We do some weird things in our codebases.
Contributor
Author
There was a problem hiding this comment.
I have updated based on the coderabbits suggestion to skip stories.tsx files.
All other comments weren't related to types not being moved correctly.
I believe everything has been resolved correctly now
kimwoodfield
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINY-12656
Description of Changes:
Pre-checks: