compiler: make composite map hashes order dependent - #5639
Merged
deadprogram merged 2 commits intoAug 31, 2026
Merged
Conversation
Use the same multiply-and-XOR combination as the runtime interface hash for generated struct and array key hashes. This avoids systematic collisions when components are permuted.
jakebailey
force-pushed
the
compiler-order-dependent-composite-hashes
branch
from
August 31, 2026 15:35
e935092 to
c306bb1
Compare
deadprogram
approved these changes
Aug 31, 2026
deadprogram
left a comment
deadprogram
left a comment
Member
There was a problem hiding this comment.
Thank you for the improvement @jakebailey and to @dgryski for review. Now merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #5581 but for the compiler hashes.